-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Base-normalization: Implement normalization
for MSSQL-destination
#6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
Connector related issues
area/worker
Related to worker
normalization
labels
Sep 15, 2021
To fix the test with column_with_quoted_names, you can have a look to see if you need this PR #6380 |
github-actions
bot
added
the
area/documentation
Improvements or additions to documentation
label
Sep 24, 2021
15 tasks
/publish connector=bases/base-normalization
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…n` (airbytehq#6079) See the attached PR (airbytehq#6079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
area/worker
Related to worker
normalization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#3430 - Implement normalization for the MSSql Destination.
How
NORMALIZATION MSSQL
array.sql, concat.sql, datatypes.sql, json_operations.sql, surrogate_key.sql, type_conversions.sql
hash.sql
macros for dbt_utils, for MS SQL Server specificallydbt_integration_test.py, test_ephemeral.py, test_normalization.py
/transform_catalog/destination_name_transformer.py
/transform_catalog/reserver_keywords.py
/transform_catalog/stream_processor.py
/transform_catalog/destination_type.py
/transform_config/transform.py
unit_tests
for MS SQL Server compatibilityAIRBYTE-WORKERS
MSSQL
type toDestinationType
enum inDefaultNormalizationRunner.java
DefaultNormalizationRunner.java
to0.1.50
.put("airbyte/destination-mssql", DefaultNormalizationRunner.DestinationType.MSSQL)
to mapping inside ofNormalizationRunnerFactory.java
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here