Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Base-normalization: Implement normalization for MSSQL-destination #6079

Merged
merged 49 commits into from
Oct 7, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Sep 15, 2021

What

#3430 - Implement normalization for the MSSql Destination.

How

NORMALIZATION MSSQL

  • edited macros for dbt_utils: array.sql, concat.sql, datatypes.sql, json_operations.sql, surrogate_key.sql, type_conversions.sql
  • added hash.sql macros for dbt_utils, for MS SQL Server specifically
  • added MS SQL Server compatibility for modules:
    • dbt_integration_test.py, test_ephemeral.py, test_normalization.py
    • /transform_catalog/destination_name_transformer.py
    • /transform_catalog/reserver_keywords.py
    • /transform_catalog/stream_processor.py
    • /transform_catalog/destination_type.py
    • /transform_config/transform.py
  • added unit_tests for MS SQL Server compatibility

AIRBYTE-WORKERS

  • added MSSQL type to DestinationType enum in DefaultNormalizationRunner.java
  • bumped the version of the default normalization image in DefaultNormalizationRunner.java to 0.1.50
  • added .put("airbyte/destination-mssql", DefaultNormalizationRunner.DestinationType.MSSQL) to mapping inside of NormalizationRunnerFactory.java

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov self-assigned this Sep 15, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/worker Related to worker normalization labels Sep 15, 2021
@bazarnov bazarnov linked an issue Sep 17, 2021 that may be closed by this pull request
@bazarnov bazarnov temporarily deployed to more-secrets September 19, 2021 13:06 Inactive
@ChristopheDuong
Copy link
Contributor

ChristopheDuong commented Sep 22, 2021

To fix the test with column_with_quoted_names, you can have a look to see if you need this PR #6380

@bazarnov bazarnov temporarily deployed to more-secrets September 24, 2021 19:38 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets September 24, 2021 19:47 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 24, 2021
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 15:59 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 6, 2021 17:23 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 18:50 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 6, 2021 19:35 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets October 6, 2021 19:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 19:39 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 20:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 08:35 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 7, 2021

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1315490217
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1315490217

@bazarnov bazarnov temporarily deployed to more-secrets October 7, 2021 09:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 09:08 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 09:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/worker Related to worker normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement normalization for the MSSql Destination.
4 participants