Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Recharge: change cursor_field from created_at on updated_at #6149

Merged

Conversation

yevhenii-ldv
Copy link
Contributor

What

closes #6020.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Sep 16, 2021

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1242529448
❌ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1242529448
🐛 https://gradle.com/s/6w6mhgxl7w7eo

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 16, 2021
@jrhizor jrhizor temporarily deployed to more-secrets September 16, 2021 17:19 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Sep 16, 2021

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1242657732
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1242657732
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 Name                          Stmts   Miss  CoverCoverage.py warning: No data was collected. (no-data-collected)
	 source_recharge/__init__.py       2      2     0%
	 source_recharge/api.py           69     69     0%
	 source_recharge/source.py        21     21     0%
	 -------------------------------------------------
	 TOTAL                            92     92     0%

@jrhizor jrhizor temporarily deployed to more-secrets September 16, 2021 18:03 Inactive
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome @yevhenii-ldv


| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| 0.1.2 | 2021-09-?? | [??](https://github.com/airbytehq/airbyte/pull/??) | Change `cursor_field` for Incremental streams |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 0.1.2 | 2021-09-?? | [??](https://github.com/airbytehq/airbyte/pull/??) | Change `cursor_field` for Incremental streams |
| 0.1.2 | 2021-09-17 | [6149](https://github.com/airbytehq/airbyte/pull/6149) | Change `cursor_field` for Incremental streams |

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Sep 17, 2021

/publish connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1245471439
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1245471439

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 12:33 Inactive
@yevhenii-ldv yevhenii-ldv merged commit 76140b5 into master Sep 17, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/change_cursor_field_incremental_recharge branch September 17, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Recharge: check correct cursor_field name
6 participants