-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source greenhouse: added identification of accessible streams for API keys with limited permissions #6238
🎉 Source greenhouse: added identification of accessible streams for API keys with limited permissions #6238
Conversation
/test connector=connectors/source-greenhouse
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments.
airbyte-integrations/connectors/source-greenhouse/source_greenhouse/client.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-greenhouse/source_greenhouse/client.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-greenhouse/integration_tests/acceptance.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can we add a sentence in the greenhouse source documentation highlighting that the connector will only process streams it has access to.
@@ -0,0 +1,3 @@ | |||
{ | |||
"api_key": "bla" | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
/publish connector=connectors/source-greenhouse
|
…nhouse-apikey-limited-access
/test connector=connectors/source-greenhouse
|
What
API key can be granted with permissions to any combinations of endpoints.
User who uses that API key might don't know a list of endpoints he has access to.
Solution: programmatically try to read each supported stream and process only 'accessible' streams during connector setup and sync
How
Describe the solution
Recommended reading order
x.java
API key can be granted with permissions to any combinations of endpoints.
User who uses that API key might don't know a list of endpoints he has access to.
Solution: programmatically try to read each supported stream and process only 'accessible' streams during connector setup and sync
2.
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes