Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6240/Add profile type filter = seller #6241

Merged
merged 2 commits into from
Sep 22, 2021
Merged

6240/Add profile type filter = seller #6241

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76061e
6240/Add profile type filter = seller
mid Sep 18, 2021
f2d9853
add type=vendor
mid Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class Profiles(AmazonAdsStream):
model = Profile

def path(self, **kvargs) -> str:
return "v2/profiles"
return "v2/profiles?profileTypeFilter=seller"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add also vendor parameter:

 return "v2/profiles?profileTypeFilter=seller,vendor"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!


def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
for record in super().parse_response(response, **kwargs):
Expand Down