Update source definition with new field #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
commented
Sep 20, 2021
| @@ -10,7 +10,7 @@ required: | |||
| - dockerRepository | |||
| - dockerImageTag | |||
| - documentationUrl | |||
| additionalProperties: false | |||
| additionalProperties: true | |||
There was a problem hiding this comment.
This may be needed to make the file-based migration system forward compatible. I will test it locally if this is necessary.
cgardens
approved these changes
Sep 20, 2021
| @@ -25,3 +25,10 @@ properties: | |||
| type: string | |||
| icon: | |||
| type: string | |||
| sourceType: | |||
There was a problem hiding this comment.
Probably not. This is in the OSS table, and we don't have preset values for custom connectors. So some entries won't have this.
subodh1810
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Thanks for doing this. Let me once this is ready to merge. As discussed over call, am closing my PR #6254 in favour of this as this one already has my changes
|
Confirmed locally that this change works as expected locally. Also there is no problem migrating from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
StandardSourceDefinitionschema forward compatible.Recommended reading order
DatabaseConfigPersistence.java