Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added externalDB password secret value #6311

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Added externalDB password secret value #6311

merged 1 commit into from
Sep 20, 2021

Conversation

minimax75
Copy link
Contributor

What

Fixes #6310

How

add "if clause" for DATABASE_PASSWORD to server-deployment.yaml template to consider externalDB secret.

Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minimax75!

@jrhizor jrhizor merged commit 9dfd2b8 into airbytehq:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm install/upgrade: ExternalDB-secrets are not considered in server deployment template
2 participants