🎉 Source MSSQL: Added support for connection via SSH tunnels (#5966) #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
|
/test connector=connectors/source-mssql
|
# Conflicts: # .github/workflows/publish-command.yml # .github/workflows/test-command.yml
irynakruk
reviewed
Sep 20, 2021
irynakruk
reviewed
Sep 20, 2021
irynakruk
reviewed
Sep 20, 2021
...rc/test-integration/java/io/airbyte/integrations/source/mssql/MssqlSourceAcceptanceTest.java
Outdated
Show resolved
Hide resolved
irynakruk
approved these changes
Sep 20, 2021
updated image version
correction of remarks
etsybaev
approved these changes
Sep 20, 2021
sherifnada
approved these changes
Sep 21, 2021
bumb image version
|
/test connector=connectors/source-mssql
|
|
/publish connector=connectors/source-mssql
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The goal of this PR is to add SSH only for the
MSSQL Source. It does not try to deal with how it can be reused for other sources or destinations.Took concept of how it was done for Postres
How
Handles injecting the SSH tunnel in the check, discover, read methods of
MSSQL sourcedirectly. This makes it relatively straightforward to inject without worrying about touching other jdbc dbs.Tested with AWS EC2 bastion and RDS MSSQL.
Recommended reading order
MssqlSource.javaAbstractSshMssqlSourceAcceptanceTest.javaCdcMssqlSourceAcceptanceTest.javaMssqlSourceAcceptanceTest.javaPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here