-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more configuration through values.yaml files #6320
Conversation
@jonstacks we use bumpversion to change version in files. Not sure, but can we add the chart files to automatically change using bumpversion? Line 21 in a6c48dc
|
@marcosmarxm, sounds like a great idea to me. I will look into it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some comments for my understanding.
## @param global.storageClass Global StorageClass for Persistent Volume(s) | ||
## | ||
global: | ||
imageRegistry: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: what does this default to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having global.imageRegistry: ""
will use dockerhub.
Example of the image generated using the default:
helm template airbyte . -s templates/scheduler/deployment.yaml | grep "image:"
image: airbyte/scheduler:0.29.21-alpha
Example of overriding this to use a private registry:
helm template airbyte . --set global.imageRegistry="my.docker.registry" -s templates/scheduler/deployment.yaml | grep "image:"
image: my.docker.registry/airbyte/scheduler:0.29.21-alpha
@@ -28,7 +28,7 @@ spec: | |||
{{- end }} | |||
containers: | |||
- name: airbyte-pod-sweeper | |||
image: "{{ .Values.podSweeper.image.repository }}:{{ .Values.podSweeper.image.tag}}" | |||
image: {{ include "airbyte.podSweeperImage" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this to use include
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah is this using the custom functions defined in _helpers.tpl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I'm using a helper function from the bitnami common library chart to make it easier to support global.imageRegistry
. Doing that in the helpers makes the main template a bit more readable IMO.
|
What
This bumps the helm chart version and allows for changing more configuration values by overwriting the values.yaml or supplying
--set
s when installing/upgrading.How
global.imageRegistry
. This makes it easier to use a private image registry for all images..Chart.appVersion
and releasing a new version of the chart. To do this, you can override the values.yaml when installing with a partial like so:Its a little verbose, but it allows changing all values independently if testing different configurations is desired.