-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Amplitude: Correct output schemas on cohorts, events, active_users, and average_session_lengths streams #6353
Conversation
/test connector=connectors/source-amplitude
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yevhenii-ldv LGTM but just a comment on the namings:
- The PR title should describe what the "actual" fix here was. The problem here was the schema files were incorrect, so title should be something closer to
:bug: source Amplitude: Correct output schemas on cohorts, events, active_users, and average_session_lengths streams
- Same thing for the changelog. The changelog is meant to be a document consumed by users, so saying "fix build" doesn't help them understand what actually changed :) it should be like checkin catalogs #1
| Version | Date | Pull Request | Subject | | ||
| :------ | :-------- | :----- | :------ | | ||
| 0.1.2 | 2021-09-?? | [????](https://github.com/airbytehq/airbyte/pull/????) | Fix build (the issue is caused by the addition of a schema check by field `format`) | | ||
| 0.1.1 | 2021-06-09 | [3973](https://github.com/airbytehq/airbyte/pull/3973) | Add AIRBYTE_ENTRYPOINT for kubernetes support | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for backfilling!
/publish connector=connectors/source-amplitude
|
What
resolves #5974.
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here