🎉 S3 source: add support for non-AWS S3 Storage #6398

avida · 2021-09-23T12:09:17Z

What

Resolves #5751

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

avida · 2021-09-23T12:09:38Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1265733052
❌ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1265733052
🐛 https://gradle.com/s/drt65ym2b4sys

avida · 2021-09-23T12:59:36Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1265899047
❌ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1265899047
🐛

avida · 2021-09-23T13:49:59Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1266082125
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1266082125
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3file.py                                                  49      3    94%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                          19      0   100%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      2    95%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     20    72%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41     28    32%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      0   100%
	 source_s3/source_files_abstract/stream.py                           183     11    94%
	 source_s3/stream.py                                                  43      3    93%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               589    107    82%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3file.py                                                  49     26    47%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                          19     11    42%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      0   100%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     19    73%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41      0   100%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      3    81%
	 source_s3/source_files_abstract/stream.py                           183     94    49%
	 source_s3/stream.py                                                  43     31    28%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               589    224    62%

avida · 2021-09-24T08:44:38Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1269120537
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1269120537
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3file.py                                                  49      3    94%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                          21      3    86%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      2    95%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     20    72%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41     28    32%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      0   100%
	 source_s3/source_files_abstract/stream.py                           183     11    94%
	 source_s3/stream.py                                                  43      3    93%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               591    110    81%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3file.py                                                  49     26    47%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                          21     13    38%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      0   100%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     19    73%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41      0   100%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      3    81%
	 source_s3/source_files_abstract/stream.py                           183     94    49%
	 source_s3/stream.py                                                  43     31    28%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               591    226    62%

yevhenii-ldv · 2021-09-24T11:16:56Z

airbyte-integrations/connectors/source-s3/acceptance-test-config.yml

      status: "succeed"
    # for Parquet format
    - config_path: "secrets/parquet_config.json"
      status: "succeed"
-    - config_path: "integration_tests/invalid_config.json"
-      status: "failed"


Please leave at least one check with the result "failed"

oops accidentally removed it

airbyte-integrations/connectors/source-s3/integration_tests/spec.json

docs/integrations/sources/s3.md

yevhenii-ldv

LGTM, small comments

Phlair

Awesome! Very cleanly implemented keeping things generic, like it!

Really just minor changes in my comments, main blocking point being the new methods sitting in source_files_abstract/__init__.py

airbyte-integrations/connectors/source-s3/acceptance-test-config.yml

airbyte-integrations/connectors/source-s3/integration_tests/acceptance.py

airbyte-integrations/connectors/source-s3/source_s3/source.py

airbyte-integrations/connectors/source-s3/integration_tests/spec.json

airbyte-integrations/connectors/source-s3/source_s3/source_files_abstract/__init__.py

Phlair · 2021-09-24T16:52:22Z

airbyte-integrations/connectors/source-s3/source_s3/source_files_abstract/source.py

@@ -81,7 +81,7 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) ->

        found_a_file = False
        try:
-            for filepath in self.stream_class.filepath_iterator(logger, config.get("provider")):
+            for filepath in self.stream_class(**config).filepath_iterator():


This was static so that during this connection check we wouldn't be instantiating an instance of the stream_class and running its init method, because our aim is purely to check connection.

I'm not against this change but curious as to why, I may be missing something.

First I've made it non static cause I was storing endpoint not in "provider" but in separate "server" field and it was pain to pass all the configs first to the filepath_iterator and then to _list_backet static functions instead of just passing self. Than I merged "server" field into "provider" and decided to keep filepath_iterator function as instance method in case we would want to pass additional parameters to those functions in the future.

avida · 2021-09-27T08:35:08Z

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1277463230
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1277463230
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3_utils.py                                                20      3    85%
	 source_s3/s3file.py                                                  49      3    94%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                           0      0   100%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      2    95%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     20    72%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41     28    32%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      0   100%
	 source_s3/source_files_abstract/stream.py                           183     11    94%
	 source_s3/stream.py                                                  43      3    93%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               590    110    81%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 source_s3/__init__.py                                                 2      0   100%
	 source_s3/s3_utils.py                                                20     13    35%
	 source_s3/s3file.py                                                  49     26    47%
	 source_s3/source.py                                                  23      0   100%
	 source_s3/source_files_abstract/__init__.py                           0      0   100%
	 source_s3/source_files_abstract/formats/abstract_file_parser.py      37      0   100%
	 source_s3/source_files_abstract/formats/csv_parser.py                71     19    73%
	 source_s3/source_files_abstract/formats/csv_spec.py                  14      0   100%
	 source_s3/source_files_abstract/formats/parquet_parser.py            41      0   100%
	 source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
	 source_s3/source_files_abstract/source.py                            40     18    55%
	 source_s3/source_files_abstract/spec.py                              42     22    48%
	 source_s3/source_files_abstract/storagefile.py                       16      3    81%
	 source_s3/source_files_abstract/stream.py                           183     94    49%
	 source_s3/stream.py                                                  43     31    28%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                               590    226    62%

avida · 2021-09-27T13:22:44Z

/publish connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1278428023
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/1278428023

github-actions bot added the area/connectors Connector related issues label Sep 23, 2021

avida temporarily deployed to more-secrets September 23, 2021 12:10 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 12:12 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch from 52e1910 to 79b4b08 Compare September 23, 2021 12:18

avida temporarily deployed to more-secrets September 23, 2021 12:20 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 12:20 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch from 79b4b08 to 583acba Compare September 23, 2021 12:42

avida temporarily deployed to more-secrets September 23, 2021 12:44 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 12:45 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch from 583acba to 42858c3 Compare September 23, 2021 12:59

avida temporarily deployed to more-secrets September 23, 2021 13:01 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 13:01 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch 2 times, most recently from 2511742 to 9bc12bb Compare September 23, 2021 13:45

avida temporarily deployed to more-secrets September 23, 2021 13:46 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 13:48 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch from 9bc12bb to 0bdf042 Compare September 23, 2021 13:49

avida temporarily deployed to more-secrets September 23, 2021 13:51 Inactive

jrhizor temporarily deployed to more-secrets September 23, 2021 13:52 Inactive

avida force-pushed the drezchykov/s3-custom-storage branch from 0bdf042 to 695515a Compare September 23, 2021 14:19

avida temporarily deployed to more-secrets September 23, 2021 14:23 Inactive

S3 source: add custom endpoint

ac84381

avida force-pushed the drezchykov/s3-custom-storage branch from 695515a to ac84381 Compare September 24, 2021 08:41

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 24, 2021

avida temporarily deployed to more-secrets September 24, 2021 08:43 Inactive

avida requested a review from htrueman September 24, 2021 08:44

avida requested review from yevhenii-ldv and Zirochkaa September 24, 2021 08:44

jrhizor temporarily deployed to more-secrets September 24, 2021 08:46 Inactive

avida changed the title ~~S3 source: add custom endpoint~~ 🎉 S3 source: add custom endpoint Sep 24, 2021

yevhenii-ldv reviewed Sep 24, 2021

View reviewed changes

airbyte-integrations/connectors/source-s3/integration_tests/spec.json Outdated Show resolved Hide resolved

yevhenii-ldv reviewed Sep 24, 2021

View reviewed changes

docs/integrations/sources/s3.md Outdated Show resolved Hide resolved

yevhenii-ldv approved these changes Sep 24, 2021

View reviewed changes

fix review comments

4d3425d

avida temporarily deployed to more-secrets September 24, 2021 12:36 Inactive

avida requested review from Phlair and sherifnada September 24, 2021 13:41

Phlair changed the title ~~🎉 S3 source: add custom endpoint~~ 🎉 S3 source: add support for non-AWS S3 Storage Sep 24, 2021

Phlair suggested changes Sep 24, 2021

View reviewed changes

fix review comments

8becd1c

avida temporarily deployed to more-secrets September 27, 2021 08:15 Inactive

avida requested a review from Phlair September 27, 2021 08:23

jrhizor temporarily deployed to more-secrets September 27, 2021 08:37 Inactive

Phlair approved these changes Sep 27, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets September 27, 2021 13:25 Inactive

avida merged commit 6767424 into master Sep 27, 2021

avida deleted the drezchykov/s3-custom-storage branch September 27, 2021 13:40

This was referenced Sep 29, 2021

Bump Airbyte version from 0.29.22-alpha to 0.30.0-alpha #6532

Closed

Bump Airbyte version from 0.29.22-alpha to 0.30.0-alpha #6539

Closed

Bump Airbyte version from 0.29.22-alpha to 0.30.0-alpha #6548

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 S3 source: add support for non-AWS S3 Storage #6398

🎉 S3 source: add support for non-AWS S3 Storage #6398

avida commented Sep 23, 2021 •

edited

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 24, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv Sep 24, 2021

avida Sep 24, 2021

yevhenii-ldv left a comment

Phlair left a comment

Phlair Sep 24, 2021

avida Sep 27, 2021

avida commented Sep 27, 2021 •

edited by github-actions bot

Loading

avida commented Sep 27, 2021 •

edited by github-actions bot

Loading

🎉 S3 source: add support for non-AWS S3 Storage #6398

🎉 S3 source: add support for non-AWS S3 Storage #6398

Conversation

avida commented Sep 23, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

avida commented Sep 23, 2021 • edited by github-actions bot Loading

avida commented Sep 23, 2021 • edited by github-actions bot Loading

avida commented Sep 23, 2021 • edited by github-actions bot Loading

avida commented Sep 24, 2021 • edited by github-actions bot Loading

yevhenii-ldv Sep 24, 2021

Choose a reason for hiding this comment

avida Sep 24, 2021

Choose a reason for hiding this comment

yevhenii-ldv left a comment

Choose a reason for hiding this comment

Phlair left a comment

Choose a reason for hiding this comment

Phlair Sep 24, 2021

Choose a reason for hiding this comment

avida Sep 27, 2021

Choose a reason for hiding this comment

avida commented Sep 27, 2021 • edited by github-actions bot Loading

avida commented Sep 27, 2021 • edited by github-actions bot Loading

avida commented Sep 23, 2021 •

edited

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 23, 2021 •

edited by github-actions bot

Loading

avida commented Sep 24, 2021 •

edited by github-actions bot

Loading

avida commented Sep 27, 2021 •

edited by github-actions bot

Loading

avida commented Sep 27, 2021 •

edited by github-actions bot

Loading