Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marcos/test pr 5747 #6516

Merged
merged 12 commits into from
Sep 28, 2021
Merged

Marcos/test pr 5747 #6516

merged 12 commits into from
Sep 28, 2021

Conversation

marcosmarxm
Copy link
Member

What

Test PR #5747

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jadetr
✅ marcosmarxm
❌ Jade Tremblay


Jade Tremblay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 28, 2021

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284210925
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284210925
🐛 https://gradle.com/s/5qnp4xgk5ncoy

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 28, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets September 28, 2021 20:32 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 28, 2021 20:33 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 28, 2021

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284303506
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284303506
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_harvest/__init__.py       2      2     0%
	 source_harvest/auth.py           9      9     0%
	 source_harvest/source.py        24     24     0%
	 source_harvest/streams.py      162    162     0%
	 ------------------------------------------------
	 TOTAL                          197    197     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  778    432    44%

@marcosmarxm marcosmarxm temporarily deployed to more-secrets September 28, 2021 21:03 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 28, 2021 21:04 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets September 28, 2021 21:34 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Sep 28, 2021

/publish connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284432266
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/1284432266

@jrhizor jrhizor temporarily deployed to more-secrets September 28, 2021 21:44 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets September 28, 2021 22:54 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets September 28, 2021 23:03 Inactive
@marcosmarxm marcosmarxm merged commit 845f84b into master Sep 28, 2021
@marcosmarxm marcosmarxm deleted the marcos/test-pr-5747 branch September 28, 2021 23:13
@marcosmarxm marcosmarxm restored the marcos/test-pr-5747 branch September 28, 2021 23:13
@marcosmarxm marcosmarxm deleted the marcos/test-pr-5747 branch September 28, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants