Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward destination location to dbt profiles #6709

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Forward destination location to dbt profiles #6709

merged 4 commits into from
Oct 6, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Oct 4, 2021 •
edited
Loading

What

BigQuery Destination can specify location of destination datasets but it is not forwarded to dbt profiles.yml file

see thread https://airbytehq.slack.com/archives/C01MFR03D5W/p1633346997101500

How

Add location when generating profiles.yml file

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/worker Related to worker normalization labels Oct 4, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets October 4, 2021 12:05 Inactive
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets October 4, 2021 12:21 Inactive
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Oct 4, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1303627045
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1303627045
🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1303627045
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1303627045

@jrhizor jrhizor temporarily deployed to more-secrets October 4, 2021 12:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 4, 2021 13:06 Inactive
@marcosmarxm
Copy link
Member

@ChristopheDuong we're waiting #6611 to publish to correct Oracle tests.

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Oct 6, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685
🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685
🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1312144685

@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets October 6, 2021 13:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 13:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 15:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 16:08 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 6, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets October 6, 2021 16:53 Inactive
@Phlair Phlair mentioned this pull request Oct 6, 2021
Merged
33 tasks
@ChristopheDuong ChristopheDuong merged commit a319642 into master Oct 6, 2021
@ChristopheDuong ChristopheDuong deleted the chris/forward-bq-location-dbt branch October 6, 2021 17:20
@jrhizor jrhizor mentioned this pull request Oct 7, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@ChristopheDuong @schlattk
Forward destination location to dbt profiles (airbytehq#6709)
a70eb60 
* Forward destination location to dbt profiles

* Format code

* Update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@harshithmullapudi harshithmullapudi harshithmullapudi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/worker Related to worker normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristopheDuong @marcosmarxm @harshithmullapudi @jrhizor