-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve link checker #6797
Merged
Merged
improve link checker #6797
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
411fbb2
improve link checker
jrhizor c1b1d47
use ref instead of base_ref
jrhizor 12ce98e
remove base, always compare to master for modified
jrhizor ebfc091
add failing to test
jrhizor f12525a
don't do quiet for testing
jrhizor 32bfe85
switch error to 404 not 403
jrhizor d02d4e8
yes to both
jrhizor 774179b
turn off verbose mode
jrhizor 021bb74
fix
jrhizor 8c91d6c
actually check things
jrhizor c2afc78
fix outstanding link problems
jrhizor f6c9fdd
revet change to run for everything
jrhizor e417b8d
Merge branch 'master' into jrhizor/improve-link-checker
jrhizor 12483ad
use new format
jrhizor 05d6760
ignore gitbook failures
jrhizor 26908c1
switch back to only running on master
jrhizor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,28 @@ | ||
# Perform link check on all markdown files | ||
name: Doc Link Checker (Full) | ||
# Add any custom exclusions to doc-link-check.json | ||
|
||
name: Doc Link Checker | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
markdown-link-check: | ||
timeout-minutes: 50 | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@master | ||
# check all files on master | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
if: github.ref == 'refs/heads/master' | ||
with: | ||
use-quiet-mode: 'no' | ||
use-verbose-mode: 'yes' | ||
use-quiet-mode: 'yes' | ||
check-modified-files-only: 'no' | ||
config-file: .github/workflows/doc-link-check.json | ||
base-branch: ${{ github.base_ref }} | ||
# check changed files for branches | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
if: github.ref != 'refs/heads/master' | ||
with: | ||
use-quiet-mode: 'yes' | ||
check-modified-files-only: 'yes' | ||
config-file: .github/workflows/doc-link-check.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also use
<!-- markdown-link-check-disable-next-line -->
by the way, which only requires one line of change.