Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉Source Clickhouse: added ssl support and "strict-encrypt" connector #7127

Merged
merged 10 commits into from
Oct 25, 2021
Merged

🎉Source Clickhouse: added ssl support and "strict-encrypt" connector #7127

merged 10 commits into from
Oct 25, 2021

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Oct 18, 2021 •
edited
Loading

What

The Source Clickhouse didn't support SSL.

How

  1. Added SSL support.
  2. Added "strict only" (SSL only) connector for cloud

Tested locally:
Capture for Clickhouse connector with SSL:
Selection_140

Capture for Clickhouse "strict-only" connector:
Selection_139

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 18, 2021
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 14:48 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 15:22 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 15:48 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 16:17 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 16:56 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1356081981
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1356081981
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 19:04 Inactive
@etsybaev
Copy link
Contributor Author

/test connector=connectors/source-clickhouse-strict-sncrypt

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 19:18 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 19:25 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 18, 2021 19:54 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 19, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse-strict-sncrypt

🕑 connectors/source-clickhouse-strict-sncrypt https://github.com/airbytehq/airbyte/actions/runs/1359236476
✅ connectors/source-clickhouse-strict-sncrypt https://github.com/airbytehq/airbyte/actions/runs/1359236476
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 13:05 Inactive
@etsybaev
Merge branch 'master' into etsybaev/6435-source-clickhouse-added-ssl-…
f4e592f 
…support

# Conflicts:
#	airbyte-integrations/connectors/source-clickhouse/src/main/java/io/airbyte/integrations/source/clickhouse/ClickHouseSource.java
#	airbyte-integrations/connectors/source-clickhouse/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/ClickHouseSourceAcceptanceTest.java
@etsybaev
Fixed merge conflict, updated docs and fix typo in module's name
70c0636
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 19, 2021
@etsybaev etsybaev temporarily deployed to more-secrets October 19, 2021 15:20 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 19, 2021 15:47 Inactive
@etsybaev etsybaev changed the title [IGNORE_IT DRAFT_PR WORK IN PROGRESS] source clickhouse added ssl support [DRAFT_PR] 🎉Source Clickhouse: added ssl support Oct 19, 2021
@etsybaev etsybaev temporarily deployed to more-secrets October 19, 2021 17:27 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 19, 2021 17:58 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 20, 2021 07:05 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 21, 2021 10:36 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 21, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1367720140
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1367720140
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 11:38 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 21, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse-strict-encrypt

🕑 connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1367797680
✅ connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1367797680
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 12:03 Inactive
This was linked to issues Oct 21, 2021
Create a secure-only Clickhouse Source #6716
Closed
Clickhouse source TLS #6435
Closed
alexandr-shegeda
alexandr-shegeda approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@etsybaev etsybaev changed the title [DRAFT_PR] 🎉Source Clickhouse: added ssl support 🎉Source Clickhouse: added ssl support and "strict-encrypt" connector Oct 21, 2021
@etsybaev etsybaev marked this pull request as ready for review October 21, 2021 13:39
@etsybaev etsybaev requested review from sherifnada and removed request for davinchia October 22, 2021 12:41
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 25, 2021 •
edited
Loading

Since all checks passed and all approval received - going to bump versions, publish and merge
Selection_150

@etsybaev etsybaev temporarily deployed to more-secrets October 25, 2021 06:52 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 25, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1380115466
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1380115466

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 08:04 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Oct 25, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-clickhouse-strict-encrypt

🕑 connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1380508563
✅ connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1380508563

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 09:53 Inactive
@etsybaev etsybaev merged commit 9a0b8da into master Oct 25, 2021
@etsybaev etsybaev deleted the etsybaev/6435-source-clickhouse-added-ssl-support branch October 25, 2021 10:33
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
@mkhokh-33 mkhokh-33 mentioned this pull request Nov 5, 2021
Merged
38 tasks
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@etsybaev @schlattk
🎉Source Clickhouse: added ssl support and "strict-encrypt" connector (a…
bdb1edb 
…irbytehq#7127)

* [Ticket 6435] Source-ClickHouse: added ssl support

* [Ticket 6716] Source-ClickHouse: added secure only connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/clickhouse connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a secure-only Clickhouse Source Clickhouse source TLS
5 participants
@etsybaev @sherifnada @alexandr-shegeda @jrhizor @igrankova