-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating license-faq #7153
Creating license-faq #7153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % the asset change.
DO you want to drop it from airbyte.io and redirect to the docs isntead?
* **Airbyte Core** is licensed under the Elastic License 2.0 (ELv2). | ||
* **Airbyte Cloud & Airbyte Enterprise** are both closed source and require a commercial license from Airbyte. | ||
|
||
![Diagram of license structure](https://assets-global.website-files.com/605e01bc25f7e19a82e74788/6142675d8f67e640a5b3b407_Screen%20Shot%202021-09-16%20at%208.36.21%20AM.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to use an image in the repo and not an external image. @avaidyanatha can you help John for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, didn't manage to make it work. need your help on this @avaidyanatha :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnlafleur Just fixed it, pushed the change up to your branch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should have a very simple mention of the license in the main readme and a link to the FAQ
@michel-tricot do you mean in addition to what is suggested in this PR?
In that case, yes indeed. |
yes something really simple. At the end of the Readme, we already have a license section. Maybe just add a quick note like: "For any question you have about ELv2, just visit xxx" |
New suggestion on this. |
* Creating license-faq * Updating links in Licenses and more details on examples * Create examples.md * Update SUMMARY.md * Update README.md * Fix license FAQ asset. * Update license-faq.md * Update license-faq.md Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@gmail.com>
We need to put the license faq a lot more forward in the docs.