Add a line prefix to the line gobbler #7200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benmoriceau if you want people to hold off on reviewing a PR, we usually just set it to draft. you can take a non-draft pr and set it to draft in the right sidebar in GH. |
@cgardens I don't see it in the UI. I have removed all assignee for now. |
|
I realized that the MDC is being display. That simplify the associated issue, the source of the log need to be added to the mdc and that should be all that is needed by the issue. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a line prefix to the line gobbler.
How
Add a new ctor parameter.
Is part of #5889