-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Zendesk chat: fix chats stream is only pulling for first page #7210
Conversation
afd74d1
to
06f0ad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run tests and publish the connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harshithmullapudi !
/test connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
53d09cf
to
4473f9b
Compare
/test connector=connectors/source-zendesk-chat
|
|
4473f9b
to
9bfcb0b
Compare
/test connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
9bfcb0b
to
36674e7
Compare
36674e7
to
7766446
Compare
7766446
to
bf530c9
Compare
/publish connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
/publish connector=connectors/source-zendesk-chat
|
airbytehq#7210) * fix: chats stream is only pulling for first page * fix: integration tests * fix: remove cred * bump version in source definition * Fixed: integration tests
What
To close #7161
How
Get next token from the response and use it in next call
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes