Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Paystack 🌟 #7214

Merged
merged 25 commits into from
Nov 1, 2021
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
052d5fd
feat(67): add support for 'spec' using Python HTTP API source templat…
folusoogunlana Oct 9, 2021
d256b81
chore(67): add sample state and config
folusoogunlana Oct 9, 2021
6da85d3
feat(67): add check functionality for paystack source by fetching fir…
folusoogunlana Oct 9, 2021
e02aecc
feat(67): add support for discover and read customer stream
folusoogunlana Oct 10, 2021
7a90777
feat(67): add paystack source connector to UI
folusoogunlana Oct 10, 2021
c40d946
Merge branch 'master' into hacktoberfest-67-paystack-source
folusoogunlana Oct 11, 2021
0babd5f
feat(67): update source definitions to use 0.1.0
folusoogunlana Oct 11, 2021
c37347c
Hacktoberfest 67 paystack source (#1)
foogunlana Oct 11, 2021
fe0e5d9
feat(67): update stream state cursor field to be integer and to match…
folusoogunlana Oct 14, 2021
ac12f55
Merge branch 'master' of https://github.com/foogunlana/airbyte
folusoogunlana Oct 14, 2021
1225e2f
chore(67): add unit tests for source and streams
folusoogunlana Oct 19, 2021
2ccdb0c
chore(67): store formatted date time in state to match type of catalog
folusoogunlana Oct 19, 2021
67207dc
chore(67): add configuration for acceptance integration tests
folusoogunlana Oct 19, 2021
125725b
docs(67): update docs and summary with paystack
folusoogunlana Oct 19, 2021
f58ea83
chore(67): add essential schemas to be catalogued for new streams
folusoogunlana Oct 19, 2021
0296fed
feat(67): add support for critical streams - transactions subscriptio…
folusoogunlana Oct 20, 2021
ec21bc8
docs(67): update image and bootstrap
folusoogunlana Oct 20, 2021
fb30fff
chore(67): update builds.md to include paystack badge
folusoogunlana Oct 20, 2021
129f455
docs(67): add changelog and source definition JSON file
folusoogunlana Oct 20, 2021
180969a
docs(67): add paystack to integrations readme
folusoogunlana Oct 20, 2021
99c6355
chore(67): update check_connection to airbyte standard
folusoogunlana Oct 23, 2021
5f8947b
refactor to simplify streams and remove constants file
folusoogunlana Oct 23, 2021
aff3d48
fix(67): correct "null, null" values in schemas
folusoogunlana Oct 23, 2021
62c3fe5
chore(67): update file formatting with gradle format
folusoogunlana Oct 23, 2021
10c1a3c
Merge remote-tracking branch 'upstream/master'
folusoogunlana Nov 1, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"sourceDefinitionId": "193bdcb8-1dd9-48d1-aade-91cadfd74f9b",
"name": "Paystack",
"dockerRepository": "airbyte/source-paystack",
"dockerImageTag": "0.1.0",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/paystack"
}

1 change: 1 addition & 0 deletions airbyte-config/init/src/main/resources/icons/paystack.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@
documentationUrl: https://docs.airbyte.io/integrations/sources/stripe
icon: stripe.svg
sourceType: api
- sourceDefinitionId: 193bdcb8-1dd9-48d1-aade-91cadfd74f9b
name: Paystack
dockerRepository: airbyte/source-paystack
dockerImageTag: 0.1.0
documentationUrl: https://docs.airbyte.io/integrations/sources/paystack
icon: paystack.svg
sourceType: api
- sourceDefinitionId: b03a9f3e-22a5-11eb-adc1-0242ac120002
name: Mailchimp
dockerRepository: airbyte/source-mailchimp
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/builds.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
| MySQL | [![source-mysql](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-mysql%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-mysql) |
| Oracle DB | [![source-oracle](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-oracle%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-oracle) |
| Paypal Transaction | [![paypal-transaction](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-paypal-transaction%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-paypal-transaction) |
| Paystack | [![source-paystack](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-paystack%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-paystack) |
| Pipedrive | [![source-pipedrive](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-pipedrive%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-pipedrive) |
| Plaid | [![source-plaid](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-plaid%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-plaid) |
| Postgres | [![source-postgres](https://img.shields.io/endpoint?url=https%3A%2F%2Fdnsgjos7lj2fu.cloudfront.net%2Ftests%2Fsummary%2Fsource-postgres%2Fbadge.json)](https://dnsgjos7lj2fu.cloudfront.net/tests/summary/source-postgres) |
Expand Down
7 changes: 7 additions & 0 deletions airbyte-integrations/connectors/source-paystack/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
*
!Dockerfile
!Dockerfile.test
!main.py
!source_paystack
!setup.py
!secrets
21 changes: 21 additions & 0 deletions airbyte-integrations/connectors/source-paystack/BOOTSTRAP.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Paystack

paystack.com is a Payment Gateway and its REST API is similar to Stripe's. This Paystack API connector is implemented with [Airbyte CDK](https://docs.airbyte.io/connector-development/cdk-python).

The Paystack API has resources including (not exhaustive)
- Customers
- Transactions - Payments and payment attempts
- Subscriptions - Recurring payments
- Invoices - Requests for payment
- Settlements - Transfers from the Paystack Gateway account to the merchant (account instance owner) bank account
- Refunds - Reversed payments

The Paystack API can be used to charge customers, and to perform CRUD operations on any of the above resources. For Airbyte only the "R" - read operations are needed, however Paystack currently supports a single secret key which can do all CRUD operations.

## Notes & Quirks
- Pagination uses the query parameters "page" (starting at 1) and "perPage".
- The standard cursor field is "createdAt" on all responses, except the "Invoices" stream which uses "created_at". It's likely the interface for this resource is either outdated or failed to be backward compatible (some other resources have both fields and some have only "createdAt").

## Useful links below
- [Paystack connector documentation](https://docs.airbyte.io/integrations/sources/paystack) - Information about specific streams and some nuances about the connector
- [Paystack dashboard](https://dashboard.paystack.com/#/settings/developer) - To grab your API token
38 changes: 38 additions & 0 deletions airbyte-integrations/connectors/source-paystack/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM python:3.7.11-alpine3.14 as base

# build and load all requirements
FROM base as builder
WORKDIR /airbyte/integration_code

# upgrade pip to the latest version
RUN apk --no-cache upgrade \
&& pip install --upgrade pip \
&& apk --no-cache add tzdata build-base


COPY setup.py ./
# install necessary packages to a temporary folder
RUN pip install --prefix=/install .

# build a clean environment
FROM base
WORKDIR /airbyte/integration_code

# copy all loaded and built libraries to a pure basic image
COPY --from=builder /install /usr/local
# add default timezone settings
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
RUN echo "Etc/UTC" > /etc/timezone

# bash is installed for more convenient debugging.
RUN apk --no-cache add bash

# copy payload code only
COPY main.py ./
COPY source_paystack ./source_paystack

ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.name=airbyte/source-paystack
132 changes: 132 additions & 0 deletions airbyte-integrations/connectors/source-paystack/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
# Paystack Source

This is the repository for the Paystack source connector, written in Python.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/paystack).

## Local development

### Prerequisites
**To iterate on this connector, make sure to complete this prerequisites section.**

#### Minimum Python version required `= 3.7.0`

#### Build & Activate Virtual Environment and install dependencies
From this connector directory, create a virtual environment:
```
python -m venv .venv
```

This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your
development environment of choice. To activate it from the terminal, run:
```
source .venv/bin/activate
pip install -r requirements.txt
pip install '.[tests]'
```
If you are in an IDE, follow your IDE's instructions to activate the virtualenv.

Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`.
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything
should work as you expect.

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-paystack:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/paystack)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_paystack/spec.json` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source paystack test creds`
and place them into `secrets/config.json`.

### Locally running the connector
```
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/source-paystack:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-paystack:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-paystack:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-paystack:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-paystack:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-paystack:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
```
### Unit Tests
To run unit tests locally, from the connector directory run:
```
python -m pytest unit_tests
```

### Integration Tests
There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all source connectors) and custom integration tests (which are specific to this connector).
#### Custom Integration tests
Place custom tests inside `integration_tests/` folder, then, from the connector root, run
```
python -m pytest integration_tests
```
#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
To run your integration tests with acceptance tests, from the connector root, run
```
python -m pytest integration_tests -p integration_tests.acceptance
```
To run your integration tests with docker

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-paystack:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-paystack:integrationTest
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
connector_image: airbyte/source-paystack:dev
tests:
spec:
- spec_path: "source_paystack/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ['disputes', 'transfers', 'settlements', 'invoices']
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env sh

# Build latest connector image
docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2)

# Pull latest acctest image
docker pull airbyte/source-acceptance-test:latest

# Run
docker run --rm -it \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /tmp:/tmp \
-v $(pwd):/test_input \
airbyte/source-acceptance-test \
--acceptance-test-config /test_input

14 changes: 14 additions & 0 deletions airbyte-integrations/connectors/source-paystack/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_paystack'
}

dependencies {
implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs)
implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#
# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("source_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
""" This fixture is a placeholder for external resources that acceptance test might require."""
yield
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
{
"streams": [
{
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite",
"stream": {
"name": "customers",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "disputes",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "invoices",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "refunds",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "settlements",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "subscriptions",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "transactions",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
},
{
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"stream": {
"name": "transfers",
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"json_schema": {}
}
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"secret_key": "sk_live_123",
"start_date": "2020-07-01T00:00:00Z"
}
Loading