Eliziario/hubspot oauth #7279
Merged
Eliziario/hubspot oauth #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avida
approved these changes
Oct 22, 2021
avida
reviewed
Oct 22, 2021
airbyte-oauth/src/main/java/io/airbyte/oauth/BaseOAuthFlow.java
Outdated
Show resolved
Hide resolved
… returns both access_token and refresh_token
avida
approved these changes
Oct 25, 2021
sherifnada
approved these changes
Oct 28, 2021
| @@ -96,31 +94,6 @@ public String getDestinationConsentUrl(final UUID workspaceId, final UUID destin | |||
| return formatConsentUrl(destinationDefinitionId, getClientIdUnsafe(oAuthParamConfig), redirectUrl); | |||
| } | |||
|
|
|||
| protected String formatConsentUrl(String clientId, | |||
There was a problem hiding this comment.
why was this removed from the base class? other oauth flows don't depend on this method?
There was a problem hiding this comment.
Actually it WAS not used. Basically all the derived classes re-implement this with a lot of commonality, but also with quite a few subtle differences. It can and it should be refactored so derived classes didn't have all those copies of only-slightly-dissimilar code, but I was planning to have a specific PR just for this and other useful refactors as adding this here was going to change too many unrelated connectors. So, it is better to have a refactors-specific PR.
|
/test connector:source-hubspot
|
|
/test connector=source-hubspot
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Hubspot OAuth backend implementation * Hubspot OAuth backend implementation - post master merge fixes * Hubspot OAuth backend implementation - missing factory * Review changes - return only refresh_token when consent flow callback returns both access_token and refresh_token * Missing import for OAuthImplementationFactory * unit test fix after merge for HubspotOAuthFlowTest * unit test fix after merge for HubspotOAuthFlowTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements backend OAuth for Hubspot connector
#7113
How
Inherit from BaseOAuthFlow, add new subclass to factory method, create integration test and unit tests
Recommended reading order
x.javaPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes