Split the check connection workflow into multiple files. #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
approved these changes
Oct 25, 2021
|
@benmoriceau, the platform build has been failing since this PR. Can you take a look? |
|
@tuliren I could have seen the error in the log, sorry about that: https://github.com/airbytehq/airbyte/runs/4000048398?check_suite_focus=true#step:17:1329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Split the check connection workflow into multiple files.
Why
We might need to add some query and signal methods at some point in order to help us to debug the temporal workflow more efficiently. That means that we will add some methods to the interface and it will be harder to read and maintain in a single file.