Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation modal #7303

Closed
wants to merge 7 commits into from
Closed

Add confirmation modal #7303

wants to merge 7 commits into from

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Oct 23, 2021 •
edited
Loading

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

@jamakase jamakase marked this pull request as ready for review December 17, 2021 09:49
@jamakase jamakase self-assigned this Dec 17, 2021
@github-actions github-actions bot added the area/platform issues related to the platform label Dec 17, 2021
@jamakase jamakase temporarily deployed to more-secrets December 17, 2021 10:06 Inactive
@jamakase jamakase temporarily deployed to more-secrets December 17, 2021 10:26 Inactive
@jamakase @jrhizor
Update airbyte-webapp/src/packages/cloud/locales/en.json
4576e36 
Co-authored-by: Jared Rhizor <jared@dataline.io>
@jamakase jamakase temporarily deployed to more-secrets December 18, 2021 11:09 Inactive
@jamakase jamakase changed the title Jamakase/confirmation modal Add confirmation modal Mar 31, 2022
@jamakase jamakase requested a review from a team as a code owner March 31, 2022 20:05
@jamakase jamakase removed their assignment Apr 1, 2022
@edmundito
Copy link
Contributor

Closing this PR. The confirmation modal was implemented in #12186

@edmundito edmundito closed this Apr 20, 2022
@edmundito edmundito deleted the jamakase/confirmation-modal branch April 20, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamakase @edmundito @jrhizor