-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubspot Source #732
Hubspot Source #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% my question about refresh token.
1. Access the api key credentials in the `hubspot-integration-test-api-key` secret on Rippling under the `Engineering` folder | ||
1. If we ever need a new api key it can be found in settings -> integrations (under the account banner) -> api key | ||
1. Access the oauth config in the `hubspot-integration-test-oauth-config` secret on Rippling under the `Engineering` folder | ||
1. If we ever need to regenerate the refresh token for auth follow these hubspot [instructions](https://developers.hubspot.com/docs/api/oauth-quickstart-guide). Going to lay out the process because it wasn't 100% clear in their docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the refresh token something that need to be generated from the integration itself instead of an input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, as in could we do the oauth within our UI and generate the refresh_token ourselves? Good thought. 2 things:
- It is not uncommon for singer taps / targets to require a refresh token. That's because there's no UI for it to do a normal oauth flow so it cheeses the oauth flow. It seems fairly standard in singer world. (both the tap-salesforce and tap-hubspot use this pattern).
- Since we have the UI, we don't necessarily need to be bound by this constraint, but we would have to add a new feature to the UI to support doing oauth and add this to the integration interface. I think I'd be in favor of doing this later, since:
- it's always already common to do it the current way in these tools and
- will be a non trivial change in both the ui and integration iface
- it will only make it easier to use our integrations, we'll just remove refresh_token from configs, so it's an easy migration for users and easy for us to maintain backwards compatibility.
does this address what you were thinking of? or am i misunderstanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does address my question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue to track us supporting oauth in a more use-friendly way: #768
@@ -0,0 +1,24 @@ | |||
plugins { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't! thank you.
What
Timer
Where did the time go
Release
oneOf
in the ui.