Hubspot Source #732
Merged
Hubspot Source #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Oct 29, 2020
| 1. Access the api key credentials in the `hubspot-integration-test-api-key` secret on Rippling under the `Engineering` folder | ||
| 1. If we ever need a new api key it can be found in settings -> integrations (under the account banner) -> api key | ||
| 1. Access the oauth config in the `hubspot-integration-test-oauth-config` secret on Rippling under the `Engineering` folder | ||
| 1. If we ever need to regenerate the refresh token for auth follow these hubspot [instructions](https://developers.hubspot.com/docs/api/oauth-quickstart-guide). Going to lay out the process because it wasn't 100% clear in their docs. |
There was a problem hiding this comment.
Isn't the refresh token something that need to be generated from the integration itself instead of an input?
There was a problem hiding this comment.
Ah, as in could we do the oauth within our UI and generate the refresh_token ourselves? Good thought. 2 things:
- It is not uncommon for singer taps / targets to require a refresh token. That's because there's no UI for it to do a normal oauth flow so it cheeses the oauth flow. It seems fairly standard in singer world. (both the tap-salesforce and tap-hubspot use this pattern).
- Since we have the UI, we don't necessarily need to be bound by this constraint, but we would have to add a new feature to the UI to support doing oauth and add this to the integration interface. I think I'd be in favor of doing this later, since:
- it's always already common to do it the current way in these tools and
- will be a non trivial change in both the ui and integration iface
- it will only make it easier to use our integrations, we'll just remove refresh_token from configs, so it's an easy migration for users and easy for us to maintain backwards compatibility.
does this address what you were thinking of? or am i misunderstanding?
There was a problem hiding this comment.
It does address my question.
There was a problem hiding this comment.
Created an issue to track us supporting oauth in a more use-friendly way: #768
jrhizor
approved these changes
Oct 29, 2020
| @@ -0,0 +1,24 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
it doesn't! thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Timer
Where did the time go
Release
oneOfin the ui.