Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack OAuthFlow Backend implementation #7328

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Slack OAuthFlow Backend implementation #7328

merged 7 commits into from
Nov 8, 2021

Conversation

eliziario
Copy link
Contributor

@eliziario eliziario commented Oct 25, 2021 •
edited
Loading

What

Implements #7116

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@eliziario eliziario marked this pull request as draft October 25, 2021 12:43
@eliziario eliziario temporarily deployed to more-secrets October 28, 2021 10:31 Inactive
@eliziario eliziario changed the title Slack OAuthFlow Slack OAuthFlow Backend implementation Oct 28, 2021
@eliziario eliziario marked this pull request as ready for review October 28, 2021 12:15
@avida avida linked an issue Nov 1, 2021 that may be closed by this pull request
oAuth backend for slack source #7116
Closed
@eliziario eliziario temporarily deployed to more-secrets November 3, 2021 13:06 Inactive
@eliziario eliziario temporarily deployed to more-secrets November 6, 2021 15:14 Inactive
@eliziario eliziario temporarily deployed to more-secrets November 8, 2021 00:13 Inactive
@eliziario eliziario merged commit 1e4bde8 into master Nov 8, 2021
@eliziario eliziario deleted the eliziario/slack_oauth_backend branch November 8, 2021 15:50
@jrhizor jrhizor mentioned this pull request Nov 8, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@eliziario @ChristopheDuong @schlattk
Slack OAuthFlow Backend implementation (airbytehq#7328)
4edff89 
* Slack OAuthFlow

* Slack OAuth Unit and Integration Tests

* Update airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java

Co-authored-by: Christophe Duong <christophe.duong@gmail.com>

* Fixes after merge for Slack OAuthFlow

Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheDuong ChristopheDuong ChristopheDuong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oAuth backend for slack source
2 participants
@eliziario @ChristopheDuong