🐛 Fix data type tests in CdcPostgresSourceDatatypeTest #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
sashaNeshcheret
changed the title
sashaNeshcheret
requested review from
DoNotPanicUA
and removed request for
etsybaev
...airbyte/integrations/io/airbyte/integration_tests/sources/CdcPostgresSourceDatatypeTest.java
Outdated
Show resolved
Hide resolved
...airbyte/integrations/io/airbyte/integration_tests/sources/CdcPostgresSourceDatatypeTest.java
Outdated
Show resolved
Hide resolved
|
@sashaNeshcheret please bump the strict-encrypt version as well |
DoNotPanicUA
previously approved these changes
Oct 26, 2021
…trict encrypt source
DoNotPanicUA
dismissed
their stale review
might be a conflict with PR #7386 Please coordinate DebeziumConverterUtils.java creation somewhere in one place.
sashaNeshcheret
changed the title
sashaNeshcheret
changed the title
|
/test connector=connectors/source-postgres-strict-encrypt
|
|
/publish connector=connectors/source-postgres-strict-encrypt
|
sashaNeshcheret
commented
Oct 30, 2021
…number and duration
…x-data-type-cdc-postgres
|
/test connector=connectors/source-postgres
|
sashaNeshcheret
deleted the
oneshcheret/5382-fix-data-type-cdc-postgres
branch
yurii-bidiuk
added a commit
that referenced
this pull request
Nov 3, 2021
lmossman
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Fix data type tests in CdcPostgresSourceComprehensiveTest * update style format * bump version for postgres source * bump version for postgres source in json definition * remove unnecessary comments from test and bump version for postgres strict encrypt source * resolved potential conflicts with debezium utils in mssql converter implementation * resolved potential conflicts with debezium utils in mssql converter implementation * Update notes for money type in postgres.md Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Update docs/integrations/sources/postgres.md Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * added test cases for converting data values for postgres cdc, remove time zone utc from test container * remove redundant void message from test Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * update style format * fix time zone in DebeziumConverterUtilsTest * set utc time zone in DataTypeUtils * set utc time zone for date format * revert changes regarding timezone in date format, disable tests with number and duration Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
yurii-bidiuk
added a commit
that referenced
this pull request
Nov 4, 2021
yurii-bidiuk
added a commit
that referenced
this pull request
Nov 5, 2021
…from mssql source (#5609) (#7386) * Fix data type (smalldatetime, smallmoney) conversion from mssql source (#5609) * Fixed code format * Bumb new version * Update documentation (mssql.md) * formating * fixed converter properties * aligned converter utils with #7339 Co-authored-by: Andrii Leonets <30464745+DoNotPanicUA@users.noreply.github.com>
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Fix data type tests in CdcPostgresSourceComprehensiveTest * update style format * bump version for postgres source * bump version for postgres source in json definition * remove unnecessary comments from test and bump version for postgres strict encrypt source * resolved potential conflicts with debezium utils in mssql converter implementation * resolved potential conflicts with debezium utils in mssql converter implementation * Update notes for money type in postgres.md Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Update docs/integrations/sources/postgres.md Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * added test cases for converting data values for postgres cdc, remove time zone utc from test container * remove redundant void message from test Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * update style format * fix time zone in DebeziumConverterUtilsTest * set utc time zone in DataTypeUtils * set utc time zone for date format * revert changes regarding timezone in date format, disable tests with number and duration Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…from mssql source (airbytehq#5609) (airbytehq#7386) * Fix data type (smalldatetime, smallmoney) conversion from mssql source (airbytehq#5609) * Fixed code format * Bumb new version * Update documentation (mssql.md) * formating * fixed converter properties * aligned converter utils with airbytehq#7339 Co-authored-by: Andrii Leonets <30464745+DoNotPanicUA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix data type tests in CdcPostgresSourceDataTypeTest
How
Created custom PostgressConvertet that implements CustomConverter
Recommended reading order
x.javay.yamlz.jsonk.mdPre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes