Save specs to source/dest definitions on create and update #7367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
cgardens
approved these changes
Oct 26, 2021
| destinationDefinitionUpdate.getDockerImageTag()); | ||
|
|
||
| final boolean imageTagHasChanged = !currentDestination.getDockerImageTag().equals(destinationDefinitionUpdate.getDockerImageTag()); | ||
| // TODO (lmossman): remove null spec condition when the spec field becomes required on the |
| @@ -104,7 +108,12 @@ public DestinationDefinitionRead getDestinationDefinition(final DestinationDefin | |||
|
|
|||
| public DestinationDefinitionRead createDestinationDefinition(final DestinationDefinitionCreate destinationDefinitionCreate) | |||
| throws JsonValidationException, IOException { | |||
| imageValidator.assertValidIntegrationImage(destinationDefinitionCreate.getDockerRepository(), | |||
| imageValidator.assertValidIntegrationImage( | |||
There was a problem hiding this comment.
is the image validator doing anything useful at this point? it seems almost entirely duplicative at this point with fetching the spec on the next line. what do you think about just totally removing it?
There was a problem hiding this comment.
Ah good catch, yeah it does seem pretty redundant now that we are fetching and using the spec in this function. Let's sweep it!
cgardens
approved these changes
Oct 27, 2021
| @@ -667,7 +665,7 @@ public boolean canImportDefinitons() { | |||
| return call.call(); | |||
| } catch (final ConfigNotFoundException e) { | |||
| throw new IdNotFoundKnownException(String.format("Could not find configuration for %s: %s.", e.getType().toString(), e.getConfigId()), | |||
| e.getConfigId(), e); | |||
| e.getConfigId(), e); | |||
There was a problem hiding this comment.
this is probably why the linting in the build is failing. 😉
There was a problem hiding this comment.
I think there is a small war happening between my intellij formatter and the gradle format command :p Still trying to get them a bit more in sync
lmossman
force-pushed
the
lmossman/save-specs-to-db-on-create
branch
from
0157beb
to
3796b65
Compare
38 tasks
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…#7367) * store spec in db * update tests * run gw format * add TODOs * add lmossman to TODOs * run gw format * remove redundant DockerImageValidator * run gw format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #7135.
Adds logic to the source/dest definition create/update API endpoints to fetch the specs from the connector container and save the spec to the definition struct in the db.
How
Uses the existing
schedulerSynchronousClientin the two handlers to fetch the spec from the connector container on create or on update if the image tag has changed or the spec is not present in the db.Recommended reading order
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes