Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk Support: fix initially_assigned_at type in ticket metrics #7377

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

asyarif93
Copy link
Contributor

What

How

change initially_assigned_at from datetime to date-time format

Recommended reading order

  1. ticket_metrics.json

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 26, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 26, 2021
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@marcosmarxm marcosmarxm merged commit c6a2a56 into airbytehq:master Nov 2, 2021
lmossman pushed a commit that referenced this pull request Nov 3, 2021
…trics (#7377)

* fix(zendesk): change initially_assigned_at format

* docs(zendesk): add change log

* build(zendesk): update connector definition
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…trics (airbytehq#7377)

* fix(zendesk): change initially_assigned_at format

* docs(zendesk): add change log

* build(zendesk): update connector definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type in Zendesk Support (Ticket Metrics)
4 participants