Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harshith/test pr 7063 #7382

Merged
merged 18 commits into from
Oct 27, 2021
Merged

Harshith/test pr 7063 #7382

merged 18 commits into from
Oct 27, 2021

Conversation

harshithmullapudi
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 26, 2021
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 26, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1384822309
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1384822309
🐛 https://gradle.com/s/ff4dzyaxit4eq

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 26, 2021 08:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 08:46 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 26, 2021 16:12 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 26, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1386521608

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 26, 2021 16:17 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 16:17 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 26, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1386606557
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1386606557
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 
	 -------------------------------------------------
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	 source_shopify/source.py        206    206     0%
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           338    338     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        206     82    60%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           338     99    71%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 26, 2021 16:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 16:43 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388369607
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388369607

@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 02:44 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388514121
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388514121

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388516001
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388516001
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	 source_shopify/source.py        211    211     0%
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           343    343     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        211     87    59%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           343    104    70%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 03:47 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 03:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 03:48 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 04:33 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388621589
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388621589
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	 source_shopify/source.py        211    211     0%
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           343    343     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        211     87    59%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           343    104    70%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 27, 2021 04:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 04:38 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 27, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388731378
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1388731378

@jrhizor jrhizor temporarily deployed to more-secrets October 27, 2021 05:25 Inactive
@harshithmullapudi harshithmullapudi merged commit e479388 into master Oct 27, 2021
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-7063 branch October 27, 2021 06:05
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Add location stream to Shopify connector

Add intentory level stream

Apply formatting

* Update doc and version configs

* Update version

* Format after rebasing

* Address review comments

* fix: location stream has no data with the current cred

* Add location stream to Shopify connector

Add intentory level stream

Apply formatting

* Update doc and version configs

* Update version

* Format after rebasing

* Address review comments

* fix: location stream has no data with the current cred

* fix: integration test

* fix: integrationtests

* fix: integrationtests

* Fixed primary key for inventory levels stream

Co-authored-by: Yuhui Shi <yuhui@convect.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants