🎉 Created destination-oracle-strict-encrypt #7460

andriikorotkov · 2021-10-28T15:52:35Z

What

Created destination-oracle-strict-encrypt

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

andriikorotkov · 2021-10-28T16:29:09Z

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1395526247
❌ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1395526247
🐛 https://gradle.com/s/4tu2rrhbzduts

andriikorotkov · 2021-10-28T16:30:15Z

/test connector=connectors/destination-oracle-strict-encrypt

🕑 connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395529808
❌ connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395529808
🐛 https://gradle.com/s/3zld2oicmfjzo

irynakruk

LGTM

andriikorotkov · 2021-10-29T07:12:32Z

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1397914077
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1397914077
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1062    403    62%

andriikorotkov · 2021-10-29T07:12:43Z

/test connector=connectors/destination-oracle-strict-encrypt

🕑 connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1397914500
✅ connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1397914500
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1062    403    62%

sherifnada · 2021-10-29T07:46:36Z

...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json

+                "description": "This parameter defines the encryption algorithm to be used",
+                "title": "Encryption Algorithm",
+                "default": "AES256",
+                "enum": ["AES256", "RC4_56", "3DES168"]


like described in the UX handbook this seems like an implementation detail. Can we just choose an algorithm so the user doesn't need to?

I will remove this from the specification, and the default value will be added in the code

sherifnada · 2021-10-29T07:47:43Z

...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json

+            }
+          },
+          {
+            "title": "TLS Encrypted (verify certificate)",


We can't use cert verification generically because it clashes with SSH tunneling like described in the "Interaction between SSH & TLS" section of the Database security RFC -- I think we should remove this for the time being

( we can remove it from the spec, no need to remove it from the code since we may want to implement it in the future)

great, I'll just take that out of the spec.

andriikorotkov · 2021-10-29T08:59:19Z

@sherifnada, I have corrected the inaccuracies indicated by you. Please, look at this pull request again.

...grations/destination/oracle_strict_encrypt/OracleStrictEncryptDestinationAcceptanceTest.java

alexandr-shegeda

minor comments added

andriikorotkov · 2021-11-01T12:12:40Z

@alexandr-shegeda, I deleted all the comments you mentioned

andriikorotkov · 2021-11-01T13:45:44Z

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1408148383
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1408148383

andriikorotkov · 2021-11-01T13:46:55Z

/publish connector=connectors/destination-oracle-strict-encrypt

🕑 connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1408152001
✅ connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1408152001

* created destination-oracle-strict-encrypt * fixed code style * updated specNormalizationValueShouldBeCorrect test * fixed remarks * fixed remarks * fixed remarks

created destination-oracle-strict-encrypt

a57e3b0

andriikorotkov requested review from irynakruk and alexandr-shegeda October 28, 2021 15:52

github-actions bot added area/connectors Connector related issues area/platform issues related to the platform area/worker Related to worker labels Oct 28, 2021

andriikorotkov linked an issue Oct 28, 2021 that may be closed by this pull request

Create a secure-only Oracle destination #6713

Closed

6 tasks

andriikorotkov temporarily deployed to more-secrets October 28, 2021 15:53 Inactive

fixed code style

0e77f5d

andriikorotkov temporarily deployed to more-secrets October 28, 2021 16:00 Inactive

jrhizor temporarily deployed to more-secrets October 28, 2021 16:32 Inactive

irynakruk approved these changes Oct 28, 2021

View reviewed changes

updated specNormalizationValueShouldBeCorrect test

c8bc774

andriikorotkov temporarily deployed to more-secrets October 29, 2021 07:13 Inactive

jrhizor temporarily deployed to more-secrets October 29, 2021 07:14 Inactive

andriikorotkov requested a review from sherifnada October 29, 2021 07:39

andriikorotkov marked this pull request as ready for review October 29, 2021 07:39

sherifnada reviewed Oct 29, 2021

View reviewed changes

fixed remarks

128860b

andriikorotkov requested a review from sherifnada October 29, 2021 08:57

andriikorotkov temporarily deployed to more-secrets October 29, 2021 08:59 Inactive

alexandr-shegeda reviewed Nov 1, 2021

View reviewed changes

...grations/destination/oracle_strict_encrypt/OracleStrictEncryptDestinationAcceptanceTest.java Outdated Show resolved Hide resolved

alexandr-shegeda reviewed Nov 1, 2021

View reviewed changes

...grations/destination/oracle_strict_encrypt/OracleStrictEncryptDestinationAcceptanceTest.java Outdated Show resolved Hide resolved

alexandr-shegeda reviewed Nov 1, 2021

View reviewed changes

...grations/destination/oracle_strict_encrypt/OracleStrictEncryptDestinationAcceptanceTest.java Outdated Show resolved Hide resolved

alexandr-shegeda approved these changes Nov 1, 2021

View reviewed changes

fixed remarks

a5f7de5

andriikorotkov temporarily deployed to more-secrets November 1, 2021 11:59 Inactive

fixed remarks

3a7575d

andriikorotkov temporarily deployed to more-secrets November 1, 2021 12:13 Inactive

sherifnada approved these changes Nov 1, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets November 1, 2021 13:48 Inactive

andriikorotkov merged commit fce6056 into master Nov 1, 2021

andriikorotkov deleted the akorotkov/6713-destination-oracle-secure-only branch November 1, 2021 15:07

jrhizor mentioned this pull request Nov 1, 2021

Bump Airbyte version from 0.30.23-alpha to 0.30.24-alpha #7532

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Created destination-oracle-strict-encrypt #7460

🎉 Created destination-oracle-strict-encrypt #7460

andriikorotkov commented Oct 28, 2021

andriikorotkov commented Oct 28, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 28, 2021 •

edited by github-actions bot

Loading

irynakruk left a comment

andriikorotkov commented Oct 29, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 29, 2021 •

edited by github-actions bot

Loading

sherifnada Oct 29, 2021

andriikorotkov Oct 29, 2021

sherifnada Oct 29, 2021

andriikorotkov Oct 29, 2021

andriikorotkov commented Oct 29, 2021

alexandr-shegeda left a comment

andriikorotkov commented Nov 1, 2021

andriikorotkov commented Nov 1, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Nov 1, 2021 •

edited by github-actions bot

Loading

🎉 Created destination-oracle-strict-encrypt #7460

🎉 Created destination-oracle-strict-encrypt #7460

Conversation

andriikorotkov commented Oct 28, 2021

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

andriikorotkov commented Oct 28, 2021 • edited by github-actions bot Loading

andriikorotkov commented Oct 28, 2021 • edited by github-actions bot Loading

irynakruk left a comment

Choose a reason for hiding this comment

andriikorotkov commented Oct 29, 2021 • edited by github-actions bot Loading

andriikorotkov commented Oct 29, 2021 • edited by github-actions bot Loading

sherifnada Oct 29, 2021

Choose a reason for hiding this comment

andriikorotkov Oct 29, 2021

Choose a reason for hiding this comment

sherifnada Oct 29, 2021

Choose a reason for hiding this comment

andriikorotkov Oct 29, 2021

Choose a reason for hiding this comment

andriikorotkov commented Oct 29, 2021

alexandr-shegeda left a comment

Choose a reason for hiding this comment

andriikorotkov commented Nov 1, 2021

andriikorotkov commented Nov 1, 2021 • edited by github-actions bot Loading

andriikorotkov commented Nov 1, 2021 • edited by github-actions bot Loading

andriikorotkov commented Oct 28, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 28, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 29, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 29, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Nov 1, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Nov 1, 2021 •

edited by github-actions bot

Loading