Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish PR 6963: new source freshsales #7585

Merged
merged 26 commits into from
Nov 3, 2021
Merged

Publish PR 6963: new source freshsales #7585

merged 26 commits into from
Nov 3, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

tuanchris and others added 21 commits October 11, 2021 18:38
@tuanchris
initial commit
21c4db5
@tuanchris
finish implementing full_refresh
bfc4306
@tuanchris
add other tables
fd5680d
@tuanchris
cleaning up
cd61452
@tuanchris
add docs and use requests_native_auth
b36175c
@tuanchris
fix function return different number of values
dac516a
@tuanchris
change package author
9fa45f6
@tuanchris
fix schema
d18a787
@tuanchris
fix schema bug
e630c11
@marcosmarxm
Merge branch '33-freshsales-source' of github.com:tuanchris/airbyte i…
d2205fd 
…nto marcos/test-pr-6963
@tuanchris
linting
420cafe
@tuanchris
fix unit test
d07834f
@marcosmarxm
Merge branch '33-freshsales-source' of github.com:tuanchris/airbyte i…
432addf 
…nto marcos/test-pr-6963
@tuanchris
clean up
b60884c
@tuanchris
add null for schemas
057ed2c
@marcosmarxm
Merge branch '33-freshsales-source' of github.com:tuanchris/airbyte i…
649b361 
…nto marcos/test-pr-6963
@marcosmarxm
Merge branch 'master' into marcos/test-pr-6963
cf86126
@tuanchris
remove fc_widget_collaboration col
a4164c8
@marcosmarxm
Merge branch '33-freshsales-source' of github.com:tuanchris/airbyte i…
2e57b8d 
…nto marcos/test-pr-6963
@marcosmarxm
Merge branch 'master' into marcos/test-pr-6963
5d99e43
@marcosmarxm
change accpt test
881e94c
@marcosmarxm marcosmarxm self-assigned this Nov 3, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 3, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-freshsales

🕑 connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/1415029160
✅ connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/1415029160
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                            Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-freshsales/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 ---------------------------------------------------
	 source_freshsales/__init__.py       2      2     0%
	 source_freshsales/source.py       118    118     0%
	 ---------------------------------------------------
	 TOTAL                             120    120     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                            Stmts   Miss  Cover
	 ---------------------------------------------------
	 source_freshsales/__init__.py       2      0   100%
	 source_freshsales/source.py       118     47    60%
	 ---------------------------------------------------
	 TOTAL                             120     47    61%

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 3, 2021 02:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 3, 2021 02:39 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-freshsales

🕑 connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/1415067036
✅ connectors/source-freshsales https://github.com/airbytehq/airbyte/actions/runs/1415067036

@jrhizor jrhizor temporarily deployed to more-secrets November 3, 2021 02:58 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 3, 2021 03:36 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 3, 2021 03:41 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 3, 2021 03:44 Inactive
@marcosmarxm marcosmarxm merged commit 0e09ac3 into master Nov 3, 2021
@marcosmarxm marcosmarxm deleted the marcos/test-pr-6963 branch November 3, 2021 04:06
@jrhizor jrhizor mentioned this pull request Nov 3, 2021
Merged
lmossman pushed a commit that referenced this pull request Nov 3, 2021
@marcosmarxm @tuanchris @lmossman
Publish PR 6963: new source freshsales (#7585)
0cb5841 
* initial commit

* finish implementing full_refresh

* add other tables

* cleaning up

* add docs and use requests_native_auth

* fix function return different number of values

* change package author

* fix schema

* fix schema bug

* linting

* fix unit test

* clean up

* add null for schemas

* remove fc_widget_collaboration col

* change accpt test

* add creds

* run format

* add config files

* run format

Co-authored-by: Tuan Nguyen <anhtuan.nguyen@me.com>
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@marcosmarxm @tuanchris @schlattk
Publish PR 6963: new source freshsales (airbytehq#7585)
b1e554a 
* initial commit

* finish implementing full_refresh

* add other tables

* cleaning up

* add docs and use requests_native_auth

* fix function return different number of values

* change package author

* fix schema

* fix schema bug

* linting

* fix unit test

* clean up

* add null for schemas

* remove fc_widget_collaboration col

* change accpt test

* add creds

* run format

* add config files

* run format

Co-authored-by: Tuan Nguyen <anhtuan.nguyen@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues connectors/source/freshsales connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosmarxm @jrhizor @igrankova @tuanchris