Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish PR 7186: destination cassandra #7685

Merged
merged 17 commits into from
Nov 5, 2021
Merged

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ marcosmarxm
✅ itaseskii
❌ itaseski


itaseski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 5, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 5, 2021

/test connector=connectors/destination-cassandra

🕑 connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1427469971
✅ connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1427469971
No Python unittests run

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 5, 2021 21:26 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 21:28 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 5, 2021

/publish connector=connectors/destination-cassandra

🕑 connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1427503240
✅ connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1427503240

@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 21:39 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 5, 2021 21:51 Inactive
@github-actions github-actions bot removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Nov 5, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 5, 2021 22:05 Inactive
@marcosmarxm marcosmarxm merged commit 9f750c2 into master Nov 5, 2021
@marcosmarxm marcosmarxm deleted the marcos/test-pr-7186 branch November 5, 2021 22:29
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* add cassandra destination connector

* refactor and docs.

* delete test dockerfile

* revert Dockerfile rm change

* refactor & fix acceptance tests & format

* revert stream peek

* remove get pip

* add address example

* improved copy and code refactor

* add docker-compose and improved docs

* config files

Co-authored-by: itaseski <ivica.taseski@seavus.com>
Co-authored-by: itaseskii <ivica.taseski94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants