-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Destination: MQTT #7718
Merged
marcosmarxm
merged 5 commits into
airbytehq:master
from
mmolimar:feature/destination-mqtt
Nov 21, 2021
Merged
🎉 New Destination: MQTT #7718
marcosmarxm
merged 5 commits into
airbytehq:master
from
mmolimar:feature/destination-mqtt
Nov 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
labels
Nov 8, 2021
Hello Mario! sorry not review this yet, can you share the integration test screnshoot showing is passing already? |
Sure! Here it is @marcosmarxm |
github-actions
bot
added
area/api
Related to the api
area/frontend
area/platform
issues related to the platform
area/protocol
area/scheduler
area/server
area/worker
Related to worker
CDK
Connector Development Kit
kubernetes
normalization
labels
Nov 21, 2021
marcosmarxm
force-pushed
the
feature/destination-mqtt
branch
from
November 21, 2021 17:02
9012ee8
to
59e271d
Compare
github-actions
bot
removed
area/platform
issues related to the platform
area/frontend
area/api
Related to the api
area/protocol
CDK
Connector Development Kit
normalization
labels
Nov 21, 2021
github-actions
bot
removed
kubernetes
area/scheduler
area/worker
Related to worker
area/server
labels
Nov 21, 2021
marcosmarxm
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution @mmolimar
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* MQTT destination * Reformat code * Updating readme * run seed Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
bounty
community
connectors/destination/mqtt
gl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Destination for MQTT.
Related with this issue part of the hacktoberfest.
And also, related with this another issue
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes