Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github: resolve refs for some schemas #7856

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Github: resolve refs for some schemas #7856

merged 2 commits into from
Nov 11, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Nov 11, 2021

What

Resolves #6883

Problem was that commit_comment_reactions' stream schema contained $ref fields. Despite it was valid reference linking to definitions section airbyte system doesnt support any refs for schema. Updated CDK version where this issue was already fixed.

@avida avida requested a review from Zirochkaa November 11, 2021 09:08
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 11, 2021
@avida
Copy link
Contributor Author

avida commented Nov 11, 2021

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1448580495
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1448580495

@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 11:41 Inactive
@avida avida temporarily deployed to more-secrets November 11, 2021 11:55 Inactive
@avida avida force-pushed the drezchykov/gh-fix branch from 2e47631 to 1e0b83f Compare November 11, 2021 12:02
@avida avida merged commit bea9bb5 into master Nov 11, 2021
@avida avida deleted the drezchykov/gh-fix branch November 11, 2021 12:04
@avida avida temporarily deployed to more-secrets November 11, 2021 12:04 Inactive
@tuliren tuliren mentioned this pull request Nov 11, 2021
16 tasks
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Github: KeyError: "'json_schema'.'properties' are not defined for stream commit_comment_reactions"
3 participants