Pipedrive oAuth support #7968
Pipedrive oAuth support #7968
Conversation
This reverts commit 0c41542.
github-actions
bot
added
area/connectors
github-actions
bot
added
the
area/documentation
avida
requested review from
eliziario,
sherifnada,
jamakase and
ChristopheDuong
and removed request for
eliziario and
sherifnada
| .put("airbyte/source-quickbooks", new QuickbooksOAuthFlow(configRepository, httpClient)) | ||
| .put("airbyte/source-pipedrive", new PipeDriveOAuthFlow(configRepository, httpClient)) |
There was a problem hiding this comment.
| .put("airbyte/source-quickbooks", new QuickbooksOAuthFlow(configRepository, httpClient)) | |
| .put("airbyte/source-pipedrive", new PipeDriveOAuthFlow(configRepository, httpClient)) | |
| .put("airbyte/source-pipedrive", new PipeDriveOAuthFlow(configRepository, httpClient)) | |
| .put("airbyte/source-quickbooks", new QuickbooksOAuthFlow(configRepository, httpClient)) |
|
@avida I have merged this not accidentally. We supposed that it will be much easier to support both formats and remove legacy one later. Are you aware what needs to be fixed to get it working with those PR? |
That was PR for temporary backend solution that is already abandoned. @ChristopheDuong is working on final solution so there is no sense of fixing it on backend side. |
| @@ -86,5 +81,13 @@ | |||
| } | |||
| }, | |||
| "supportsIncremental": true, | |||
| "supported_destination_sync_modes": ["append"] | |||
| "supported_destination_sync_modes": ["append"], | |||
There was a problem hiding this comment.
since this is a source, is that normal to set destination modes?
There was a problem hiding this comment.
oops, missed that, will remove
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class PipeDriveOAuthFlowTest { |
There was a problem hiding this comment.
Sorry, could you update your branch and make the unit test extends from BaseOAuthTestFlow?
There was a problem hiding this comment.
Wow, nice refactoring, I love it
|
/publish connector=connectors/source-pipedrive
|
|
/publish connector=connectors/source-pipedrive
|
|
@avida It looks like this PR broke the platform build, as it removed Could you submit a PR to fix the lock file please? |
Resolves #7512
Also reverts 0c41542 commit that was merged by mistake with #7325 and causes 422 response for oAuth requests (Chris working on another backend implementation).