🎉 Source Zendesk Sunshine: support oauth #7976

annalvova05 · 2021-11-15T13:24:54Z

What

#7708 Add oauth2.0 flow part for Zendesk Sunshine.

How

Change spec.json and implement new Auth method in source.py

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/source.py

airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/streams.py

…-sunshine-oauth # Conflicts: # airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/325e0640-e7b3-4e24-b823-3361008f603f.json # tools/bin/ci_credentials.sh

…-sunshine-oauth

bazarnov

LGTM, with a little question regards having primary_key inside of parent class. Check it, please.

airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/streams.py

annalvova05 · 2021-12-29T23:08:30Z

/test connector=connectors/source-zendesk-sunshine

🕑 connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1635667928
❌ connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1635667928
🐛 https://gradle.com/s/ik65phb7prqva
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs4] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs5] - docker.errors.Cont...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 18 passed, 1 skipped in 132.78s (0:02:12) ==============

annalvova05 · 2021-12-30T08:46:05Z

/test connector=connectors/source-zendesk-sunshine

🕑 connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1636872312
✅ connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1636872312
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 20 passed, 1 skipped in 135.14s (0:02:15) ===================

…-sunshine-oauth

annalvova05 · 2022-01-04T18:33:09Z

Java tests was passed

antixar

LGTM! Please publish this

annalvova05 · 2022-01-04T20:42:37Z

/test connector=connectors/source-zendesk-sunshine

🕑 connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1655479873
✅ connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1655479873
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 20 passed, 1 skipped in 132.64s (0:02:12) ===================

annalvova05 · 2022-01-04T20:56:34Z

/publish connector=connectors/source-zendesk-sunshine

🕑 connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1655523762
✅ connectors/source-zendesk-sunshine https://github.com/airbytehq/airbyte/actions/runs/1655523762

add oauth support

2a31956

annalvova05 requested review from antixar and bazarnov November 15, 2021 13:24

annalvova05 self-assigned this Nov 15, 2021

annalvova05 linked an issue Nov 15, 2021 that may be closed by this pull request

Source Zendesk Sunshine: support oauth #7708

Closed

github-actions bot added the area/connectors Connector related issues label Nov 15, 2021

bump version

bf5f19e

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 15, 2021

annalvova05 temporarily deployed to more-secrets November 15, 2021 13:33 Inactive

bazarnov requested changes Nov 16, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into alvova/7708-zendesk…

903c4bf

…-sunshine-oauth # Conflicts: # airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/325e0640-e7b3-4e24-b823-3361008f603f.json # tools/bin/ci_credentials.sh

annalvova05 temporarily deployed to more-secrets December 29, 2021 14:01 Inactive

add java part

456c7b8

annalvova05 temporarily deployed to more-secrets December 29, 2021 18:33 Inactive

annalvova05 added 2 commits December 29, 2021 20:34

change date format

8615244

Merge remote-tracking branch 'origin/master' into alvova/7708-zendesk…

e20f0f8

…-sunshine-oauth

annalvova05 temporarily deployed to more-secrets December 29, 2021 18:37 Inactive

bazarnov approved these changes Dec 29, 2021

View reviewed changes

airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/streams.py Show resolved Hide resolved

change spec

7c5cd74

annalvova05 temporarily deployed to more-secrets December 29, 2021 23:02 Inactive

jrhizor temporarily deployed to more-secrets December 29, 2021 23:10 Inactive

upd invalid_configs

e004679

annalvova05 temporarily deployed to more-secrets December 30, 2021 08:47 Inactive

jrhizor temporarily deployed to more-secrets December 30, 2021 08:48 Inactive

Merge remote-tracking branch 'origin/master' into alvova/7708-zendesk…

98e78dd

…-sunshine-oauth

antixar approved these changes Jan 4, 2022

View reviewed changes

jrhizor temporarily deployed to more-secrets January 4, 2022 20:45 Inactive

annalvova05 temporarily deployed to more-secrets January 4, 2022 20:46 Inactive

jrhizor temporarily deployed to more-secrets January 4, 2022 20:58 Inactive

bump version and format

56cbf81

annalvova05 temporarily deployed to more-secrets January 4, 2022 21:11 Inactive

annalvova05 merged commit 7776dbe into master Jan 4, 2022

annalvova05 deleted the alvova/7708-zendesk-sunshine-oauth branch January 4, 2022 21:15

jrhizor mentioned this pull request Jan 7, 2022

Bump Airbyte version from 0.35.3-alpha to 0.35.4-alpha #9353

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Zendesk Sunshine: support oauth #7976

🎉 Source Zendesk Sunshine: support oauth #7976

annalvova05 commented Nov 15, 2021 •

edited

Loading

bazarnov left a comment

annalvova05 commented Dec 29, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 30, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Jan 4, 2022

antixar left a comment

annalvova05 commented Jan 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jan 4, 2022 •

edited by github-actions bot

Loading

🎉 Source Zendesk Sunshine: support oauth #7976

🎉 Source Zendesk Sunshine: support oauth #7976

Conversation

annalvova05 commented Nov 15, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

bazarnov left a comment

Choose a reason for hiding this comment

annalvova05 commented Dec 29, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 30, 2021 • edited by github-actions bot Loading

annalvova05 commented Jan 4, 2022

antixar left a comment

Choose a reason for hiding this comment

annalvova05 commented Jan 4, 2022 • edited by github-actions bot Loading

annalvova05 commented Jan 4, 2022 • edited by github-actions bot Loading

annalvova05 commented Nov 15, 2021 •

edited

Loading

annalvova05 commented Dec 29, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 30, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Jan 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jan 4, 2022 •

edited by github-actions bot

Loading