Generate API code + bootstrap webserver + simplify launch #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
approved these changes
Aug 5, 2020
| } | ||
|
|
||
| @Override | ||
| public void deletePet(Long petId, String apiKey) { |
| task fatjar(type: Jar) { | ||
| manifest { | ||
| attributes 'Main-Class': 'io.dataline.playground.HelloWorld' | ||
| testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.4.2' |
There was a problem hiding this comment.
is this needed if we are importing it as testImplementation?
There was a problem hiding this comment.
not the same lib
There was a problem hiding this comment.
late night double vision
| @@ -3,13 +3,15 @@ FROM gradle:jdk14 AS build | |||
|
|
|||
| COPY . /code | |||
| WORKDIR /code | |||
| RUN gradle fatjar --no-daemon | |||
| RUN gradle distTar --no-daemon | |||
There was a problem hiding this comment.
any particular reason to use tar vs jar?
There was a problem hiding this comment.
I try to follow the gradle way of distributing. I ran into a lot of problem with the server piece when I tried to create a fatjar.
cgardens
approved these changes
Aug 5, 2020
jrhizor
approved these changes
Aug 5, 2020
mohamagdy
added a commit
to mohamagdy/airbyte
that referenced
this pull request
May 1, 2022
…-dbt Filter out `None` items
37 tasks
This was referenced Oct 28, 2022
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.