-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hubspot: adding form_submissions stream #8011
Source Hubspot: adding form_submissions stream #8011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, thanks for the contributions!
airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py
Outdated
Show resolved
Hide resolved
0c022df
to
5058172
Compare
thanks @gergelylendvai sorry the long delay in reply. could you share the output from integration tests? you can run |
hey @marcosmarxm, I've run the tests with most of the streams commented out, leaving only
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @gergelylendvai
What
Added new
form_submissions
stream to HubSpot sourceHow
Getting the submissions can be achieved with the
v1
api however for fetching the formsv3
orv2
has to be used.🚨 User Impact 🚨
There is an additional stream which can be selected during the connection setup.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here