Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: adding form_submissions stream #8011

Merged
merged 12 commits into from
Jan 14, 2022

Conversation

gergelylendvai
Copy link
Contributor

What

Added new form_submissions stream to HubSpot source

How

Getting the submissions can be achieved with the v1 api however for fetching the forms v3 or v2 has to be used.

🚨 User Impact 🚨

There is an additional stream which can be selected during the connection setup.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 16, 2021
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, thanks for the contributions!

@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/protocol area/scheduler area/server CDK Connector Development Kit normalization labels Jan 7, 2022
@gergelylendvai gergelylendvai force-pushed the hubspot-form-submissions branch from 0c022df to 5058172 Compare January 7, 2022 14:56
@github-actions github-actions bot removed area/platform issues related to the platform area/api Related to the api area/protocol normalization area/scheduler CDK Connector Development Kit area/server labels Jan 7, 2022
@marcosmarxm
Copy link
Member

thanks @gergelylendvai sorry the long delay in reply. could you share the output from integration tests? you can run ./gradlew airbyte-integrations:connectors:source-hubspot:integrationTest. If you don't have access to all streams please comment them in integration_tests/configured_catalog.json.

@gergelylendvai
Copy link
Contributor Author

hey @marcosmarxm, I've run the tests with most of the streams commented out, leaving only form_submissions and subscription_changes (to also have a stream for the incremental tests) and the tests managed to succeed after the schema was fixed. Also I didn't have oauth configs for Hubspot so I've used just the config with an API key.

BUILD SUCCESSFUL in 4m 56s
81 actionable tasks: 44 executed, 37 up-to-date

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 13, 2022
@marcosmarxm marcosmarxm temporarily deployed to more-secrets January 13, 2022 23:34 Inactive
@marcosmarxm marcosmarxm merged commit 9cc2560 into airbytehq:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants