-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Source Monday: support oauth #8172
Conversation
…oauth # Conflicts: # airbyte-integrations/connectors/source-monday/source_monday/source.py
/test connector=connectors/source-monday
|
/test connector=connectors/source-monday
|
…oauth # Conflicts: # airbyte-integrations/connectors/source-monday/source_monday/spec.json
/test connector=connectors/source-monday
|
…oauth # Conflicts: # airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add standard Java tests for oauth logic
airbyte-integrations/connectors/source-monday/source_monday/spec.json
Outdated
Show resolved
Hide resolved
"api_token": { | ||
"type": "string", | ||
"title": "Personal Access Token", | ||
"description": "Access Token for making authenticated requests.", | ||
"airbyte_secret": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is API token or access token?
"auth_type": { | ||
"type": "string", | ||
"const": "Client", | ||
"enum": ["Client"], | ||
"default": "Client" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only one auth method. where will use this "auth_type" property?
/test connector=connectors/source-monday
|
@antixar updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please publish your changes
/test connector=connectors/source-monday
|
/publish connector=connectors/source-monday
|
What
Add oauth2.0 support
How
Change
spec.json
, addMondayOAuthFlow.java
.OAuth Sreenshots of working flow:
Recommended reading order
spec.json
source.py
MondayOAuthFlow.java
🚨 User Impact 🚨
Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here