-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Intercom: Fix conversations order and sorting #8579
🐛 Source Intercom: Fix conversations order and sorting #8579
Conversation
/test connector=connectors/source-intercom
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please merge it but without publishing.
Now I'm fixing another Intercom bug. and I will publish your and my changes together
* Fix conversations order and sorting * Updated PR number
@lazebnyi can you explain why this solves the issue? Intercom's conversations are default sorted by Specifically, the Intercom connector currently iterates over every conversation page, even in incremental sync. This causes it to take many hours (@sean-mckeever is also seeing this issue: #9572 (comment)). I am working on a fix by sorting by desc and cutting off the pagination when we hit the appropriate |
What
#8475 - Source Intercom: missing records from conversation stream
How
Records missing during sync because the Intercom connector has a logic to filter based on the cursor field and records weren't ordered and sorted. Now add query params to request
order=asc&sort=updated_at
(whereupdated_at
iscursor_field
).Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here