Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Zendesk Support: Adds Brands, CustomRoles and Schedules #8616

Merged
merged 8 commits into from
Dec 17, 2021

Conversation

asyarif93
Copy link
Contributor

What

  • Some analysis might need brand associated with tickets.
  • Some analysis might need to check which roles given to agents.

How

Adds brands and custom_roles to schema

Recommended reading order

  1. streams.py
  2. source.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 8, 2021
@asyarif93
Copy link
Contributor Author

unit test results

python -m pytest -s unit_testsTest session starts (platform: darwin, Python 3.9.7, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/lpt-718/projects/airbyte, configfile: pytest.ini
plugins: requests-mock-1.9.3, sugar-0.9.4, timeout-1.4.2
collecting ... 
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After-123-123] ✓           9% ▉         
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After--123-None] ✓        18% █▊        
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit-100-1.2] ✓         27% ██▊       
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit--100-None] ✓       36% ███▋      
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Fake-Header--100-None] ✓        45% ████▋     
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[200-1-None] ✓       55% █████▌    {"type": "LOG", "log": {"level": "INFO", "message": "ticket 12345 not found (404 error). It could have been deleted."}}

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[404-0-None] ✓ 64% ██████▍
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[403-0-HTTPError] ✓ 73% ███████▍
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_transform_for_tickets_stream[input_data0-expected_data0] ✓82% ████████▎
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_transform_for_tickets_stream[input_data1-expected_data1] ✓91% █████████▏
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_transform_for_tickets_stream[input_data2-expected_data2] ✓100% ██████████
================================================================ warnings summary ================================================================
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py: 59 warnings
/Users/lpt-718/projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:37: DeprecationWarning: Call to deprecated class NoAuth. (Set authenticator=None instead) -- Deprecated since version 0.1.20.
self._authenticator = NoAuth()

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py: 59 warnings
/Users/lpt-718/projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.9/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.51s):
11 passed

@asyarif93
Copy link
Contributor Author

/test connector=connectors/source-zendesk-support

@asyarif93 asyarif93 changed the title 🎉 Source Zendesk Support: Adds Brands and CustomRoles 🎉 Source Zendesk Support: Adds Brands, CustomRoles and Schedules Dec 13, 2021
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @asyarif93 ! Soon I'll publish your contribution!

@marcosmarxm marcosmarxm self-assigned this Dec 16, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 17, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets December 17, 2021 03:44 Inactive
@marcosmarxm marcosmarxm merged commit 9f9e924 into airbytehq:master Dec 17, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…bytehq#8616)

* feat(zendesk): Add Brands and CustomRoles

* style(zendesk): reformat using gradlew

* fix(zendesk): format created_at and updated_at to date-time format

* feat(zendesk): add business hours schedule

* bump connector version

* run seed file

Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants