🎉 Source Hubspot: Support incremental sync on all possible streams #8699

lazebnyi · 2021-12-10T12:50:24Z

What

#8344 - Hubspot: Support incremental sync on all possible streams

How

Add server side records filtering by state for companies, contact_lists, contacts, deals, line_items, products, quotes, tickets streams.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

…deals, line_items, products, quotes, tickets streams

lazebnyi · 2021-12-10T12:52:12Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563478335
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563478335
🐛 https://gradle.com/s/ppl6ezvxm6jqs

lazebnyi · 2021-12-10T13:08:14Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563535132
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563535132
🐛 https://gradle.com/s/lxthdruygh6yg

lazebnyi · 2021-12-10T13:45:09Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563675384
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563675384
🐛 https://gradle.com/s/n4ldss7pcgeui

lazebnyi · 2021-12-10T14:39:24Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563877274
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1563877274
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_hubspot/__init__.py       2      0   100%
	 source_hubspot/api.py          407     64    84%
	 source_hubspot/client.py        40     12    70%
	 source_hubspot/errors.py         6      0   100%
	 source_hubspot/source.py         4      0   100%
	 ------------------------------------------------
	 TOTAL                          459     76    83%

antixar

Good stuff!
Please check my minor comments please

airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py

airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml

airbyte-integrations/connectors/source-hubspot/integration_tests/abnormal_state.json

lazebnyi · 2021-12-16T14:05:44Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1587823264
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1587823264
🐛 https://gradle.com/s/3v62ezd7px3du
Python short test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 1 failed, 19 passed in 65.43s (0:01:05) ====================

lazebnyi · 2021-12-16T14:33:36Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1587943641
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1587943641
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  965    458    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_hubspot/__init__.py       2      0   100%
	 source_hubspot/api.py          407     64    84%
	 source_hubspot/client.py        40     12    70%
	 source_hubspot/errors.py         6      0   100%
	 source_hubspot/source.py         4      0   100%
	 ------------------------------------------------
	 TOTAL                          459     76    83%

antixar

Looks good!
Please publish this enchantment

lazebnyi · 2021-12-17T13:37:30Z

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1592464918
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1592464918

…irbytehq#8699) * Add incremental sync support for companies, contact_lists, contacts, deals, line_items, products, quotes, tickets streams * Updated PR number * Fix formating * Fix typo * Commented unsupported tests * Updated to review * Updated abnormal state file * Deleted comment * Updated version in docker * Updated version in spec yaml and seed

Add incremental sync support for companies, contact_lists, contacts, …

deb24b8

…deals, line_items, products, quotes, tickets streams

lazebnyi linked an issue Dec 10, 2021 that may be closed by this pull request

Hubspot: Support incremental sync on all possible streams #8344

Closed

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 10, 2021

lazebnyi requested review from midavadim and antixar December 10, 2021 12:51

Updated PR number

02c77bf

lazebnyi temporarily deployed to more-secrets December 10, 2021 12:54 Inactive

Fix formating

76cc6b1

lazebnyi temporarily deployed to more-secrets December 10, 2021 13:09 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 13:10 Inactive

Fix typo

c039ad7

lazebnyi temporarily deployed to more-secrets December 10, 2021 13:46 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 13:47 Inactive

Commented unsupported tests

c75b1c8

lazebnyi temporarily deployed to more-secrets December 10, 2021 14:40 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 14:41 Inactive

lazebnyi changed the title ~~Source Hubspot: Support incremental sync on all possible streams~~ 🎉 Source Hubspot: Support incremental sync on all possible streams Dec 13, 2021

antixar reviewed Dec 15, 2021

View reviewed changes

lazebnyi added 2 commits December 16, 2021 16:00

Merged master to branch

8a2f00b

Updated to review

d7c6bfe

lazebnyi temporarily deployed to more-secrets December 16, 2021 14:05 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 14:07 Inactive

Updated abnormal state file

74c3618

lazebnyi temporarily deployed to more-secrets December 16, 2021 14:34 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 14:35 Inactive

Deleted comment

adaa2cc

lazebnyi requested a review from antixar December 16, 2021 14:44

lazebnyi temporarily deployed to more-secrets December 16, 2021 14:45 Inactive

antixar approved these changes Dec 17, 2021

View reviewed changes

lazebnyi added 2 commits December 17, 2021 15:33

Merged master to branch

12d439c

Updated version in docker

d7f47c5

lazebnyi temporarily deployed to more-secrets December 17, 2021 13:37 Inactive

lazebnyi marked this pull request as ready for review December 17, 2021 13:38

jrhizor temporarily deployed to more-secrets December 17, 2021 13:39 Inactive

Updated version in spec yaml and seed

d1c5a78

lazebnyi merged commit 212c1ff into master Dec 17, 2021

lazebnyi deleted the lazebnyi/8344-hubspot-add-incremental-support branch December 17, 2021 13:48

lazebnyi temporarily deployed to more-secrets December 17, 2021 13:50 Inactive

This was referenced Dec 19, 2021

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8900

Merged

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8901

Merged

vitaliizazmic mentioned this pull request Jan 17, 2022

🐛 Source Hubspot: Fix SAT incremental tests #6509

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Hubspot: Support incremental sync on all possible streams #8699

🎉 Source Hubspot: Support incremental sync on all possible streams #8699

lazebnyi commented Dec 10, 2021

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

antixar left a comment

lazebnyi commented Dec 16, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 16, 2021 •

edited by github-actions bot

Loading

antixar left a comment

lazebnyi commented Dec 17, 2021 •

edited by github-actions bot

Loading

🎉 Source Hubspot: Support incremental sync on all possible streams #8699

🎉 Source Hubspot: Support incremental sync on all possible streams #8699

Conversation

lazebnyi commented Dec 10, 2021

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

lazebnyi commented Dec 10, 2021 • edited by github-actions bot Loading

lazebnyi commented Dec 10, 2021 • edited by github-actions bot Loading

lazebnyi commented Dec 10, 2021 • edited by github-actions bot Loading

lazebnyi commented Dec 10, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

lazebnyi commented Dec 16, 2021 • edited by github-actions bot Loading

lazebnyi commented Dec 16, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

lazebnyi commented Dec 17, 2021 • edited by github-actions bot Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 10, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 16, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 16, 2021 •

edited by github-actions bot

Loading

lazebnyi commented Dec 17, 2021 •

edited by github-actions bot

Loading