🐛 Source: Strava: support OAuth 2.0 #8799

grubberr · 2021-12-14T22:53:07Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2021-12-15T11:10:05Z

/test connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1582425751
✅ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1582425751
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            89     64    28%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/cdk/utils/event_timing.py         47      3    94%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     15    55%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        713    397    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_strava/__init__.py       2      0   100%
	 source_strava/source.py        18      9    50%
	 source_strava/streams.py       46     11    76%
	 -----------------------------------------------
	 TOTAL                          66     20    70%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
======================== 14 passed, 1 skipped in 22.38s ========================

bazarnov

Looks good, any Python code changes or there is nothing to do with it?

antixar

looks good!
Please publish this

grubberr · 2021-12-15T15:08:17Z

@bazarnov yes, python part worked on OAUTH 2.0 already

This reverts commit 4d7ede6.

grubberr · 2021-12-15T15:14:23Z

/test connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583356800
❌ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583356800
🐛 https://gradle.com/s/2hizxloduqrb2

grubberr · 2021-12-15T15:44:22Z

/test connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583476334
✅ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583476334
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  965    458    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            89     64    28%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/cdk/utils/event_timing.py         47      3    94%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     15    55%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        713    397    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_strava/__init__.py       2      0   100%
	 source_strava/source.py        18      9    50%
	 source_strava/streams.py       46     11    76%
	 -----------------------------------------------
	 TOTAL                          66     20    70%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
======================== 14 passed, 1 skipped in 23.87s ========================

grubberr · 2021-12-15T16:50:53Z

/publish connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583738545
✅ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1583738545

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* OAuth 2.0 added Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

OAuth 2.0 added

920430d

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Dec 14, 2021

grubberr self-assigned this Dec 14, 2021

grubberr linked an issue Dec 14, 2021 that may be closed by this pull request

Source Strava: support oauth #8008

Closed

StravaOAuthFlowTest.java added

7cca069

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 14, 2021

grubberr temporarily deployed to more-secrets December 14, 2021 23:03 Inactive

grubberr added 2 commits December 15, 2021 13:07

Merge branch 'master' into grubberr/8008-source-strava

dd76450

github secret -> GSM

4d7ede6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets December 15, 2021 11:14 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 11:15 Inactive

grubberr requested review from antixar and bazarnov December 15, 2021 11:22

bazarnov approved these changes Dec 15, 2021

View reviewed changes

antixar approved these changes Dec 15, 2021

View reviewed changes

grubberr added 2 commits December 15, 2021 17:13

Revert "github secret -> GSM"

26ca058

This reverts commit 4d7ede6.

Merge branch 'master' into grubberr/8008-source-strava

30d1e1d

grubberr temporarily deployed to more-secrets December 15, 2021 15:15 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 15:16 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 15:46 Inactive

Merge branch 'master' into grubberr/8008-source-strava

185045c

grubberr temporarily deployed to more-secrets December 15, 2021 16:52 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 16:52 Inactive

source_specs.yaml updated

b1ad4ca

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit 39b62d6 into master Dec 15, 2021

grubberr deleted the grubberr/8008-source-strava branch December 15, 2021 17:31

grubberr temporarily deployed to more-secrets December 15, 2021 17:31 Inactive

jrhizor mentioned this pull request Dec 16, 2021

Bump Airbyte version from 0.33.12-alpha to 0.34.0-alpha #8834

Merged

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

🐛 Source: Strava: support OAuth 2.0 (airbytehq#8799)

dec9bee

* OAuth 2.0 added Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source: Strava: support OAuth 2.0 #8799

🐛 Source: Strava: support OAuth 2.0 #8799

grubberr commented Dec 14, 2021 •

edited

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

bazarnov left a comment

antixar left a comment

grubberr commented Dec 15, 2021

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

🐛 Source: Strava: support OAuth 2.0 #8799

🐛 Source: Strava: support OAuth 2.0 #8799

Conversation

grubberr commented Dec 14, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Dec 15, 2021 • edited by github-actions bot Loading

bazarnov left a comment

Choose a reason for hiding this comment

antixar left a comment

Choose a reason for hiding this comment

grubberr commented Dec 15, 2021

grubberr commented Dec 15, 2021 • edited by github-actions bot Loading

grubberr commented Dec 15, 2021 • edited by github-actions bot Loading

grubberr commented Dec 15, 2021 • edited by github-actions bot Loading

grubberr commented Dec 14, 2021 •

edited

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 15, 2021 •

edited by github-actions bot

Loading