Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 SAT: add assert that spec.json file does not have any $ref in it #8842

Merged
merged 4 commits into from
Dec 17, 2021
Merged

🎉 SAT: add assert that spec.json file does not have any $ref in it #8842

merged 4 commits into from
Dec 17, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Dec 16, 2021 •
edited
Loading

What

Closes #8288.

How

Add a new test to TestSpec testcase which checks that there are no $ref fields in spec.json file.

@Zirochkaa Zirochkaa self-assigned this Dec 16, 2021
@Zirochkaa Zirochkaa changed the title SAT: add assert that spec.json file does not have any $ref in it 🎉 SAT: add assert that spec.json file does not have any $ref in it Dec 16, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 16, 2021 •
edited by github-actions bot
Loading

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1587962532
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1587962532
No Python unittests run

@Zirochkaa Zirochkaa temporarily deployed to more-secrets December 16, 2021 14:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 14:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 14:45 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 16, 2021 •
edited by github-actions bot
Loading

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1588746017
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1588746017
No Python unittests run

@Zirochkaa Zirochkaa temporarily deployed to more-secrets December 16, 2021 17:52 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 17:53 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 16, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1588771173
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1588771173
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              245     96    61%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  975    459    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_github/__init__.py       2      0   100%
	 source_github/source.py        76     34    55%
	 source_github/streams.py      367    176    52%
	 -----------------------------------------------
	 TOTAL                         445    210    53%

@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 18:00 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 17, 2021 •
edited by github-actions bot
Loading

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591399095
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591399095
No Python unittests run

@Zirochkaa Zirochkaa temporarily deployed to more-secrets December 17, 2021 08:52 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 17, 2021 08:53 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 17, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1591415130
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1591415130
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  972    459    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_github/__init__.py       2      0   100%
	 source_github/source.py        76     34    55%
	 source_github/streams.py      367    176    52%
	 -----------------------------------------------
	 TOTAL                         445    210    53%

@jrhizor jrhizor temporarily deployed to more-secrets December 17, 2021 08:58 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 17, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591521788
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591521788

@jrhizor jrhizor temporarily deployed to more-secrets December 17, 2021 09:25 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Dec 17, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591671389
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1591671389

@Zirochkaa Zirochkaa temporarily deployed to more-secrets December 17, 2021 10:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 17, 2021 10:05 Inactive
@Zirochkaa Zirochkaa merged commit 6889a89 into master Dec 17, 2021
@Zirochkaa Zirochkaa deleted the oleh/8288-validate-refs-in-spec-file branch December 17, 2021 10:12
This was referenced Dec 19, 2021
Merged
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@Zirochkaa @schlattk
🎉 SAT: add assert that spec.json file does not have any $ref in it (a…
a4a2b84 
…irbytehq#8842)

* 8288 Add assert that spec.json file does not have any `$ref` in it

* 8288 Format

* 8288 Remove unused lines

* 8288 Bump SAT version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

@htrueman htrueman Awaiting requested review from htrueman

@sergei-solonitcyn sergei-solonitcyn Awaiting requested review from sergei-solonitcyn

Assignees

@Zirochkaa Zirochkaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAT should validate no $refs used in spec.json
3 participants
@Zirochkaa @yevhenii-ldv @jrhizor