Remove nested secrets #8859
Merged
Remove nested secrets #8859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
force-pushed
the
oc/remove-nested-secrets
branch
from
325650e
to
b33e85f
Compare
benmoriceau
force-pushed
the
oc/remove-nested-secrets
branch
from
b33e85f
to
fe51c76
Compare
jrhizor
approved these changes
Dec 17, 2021
benmoriceau
added a commit
that referenced
this pull request
Dec 18, 2021
explore all the nodes to mask secrets, even if they are arrays or nested at a given deep level. It makes what has been made in #8859 more generic
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
explore all the nodes to mask secrets, even if they are arrays or nested at a given deep level. It makes what has been made in airbytehq#8859 more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
if the properties definitions are nested in a properties object, the secret were not masked. This is fixing it.