Source CockroachDB: handled case when user can see only tables with select grants #9004

sashaNeshcheret · 2021-12-21T16:21:46Z

What

Handled case when user can see only tables with select grants, previously during discovery we fetch all tables regardless permissions.

How

Fetch tables names where user has select or all permissions and filter other tables from result.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

sashaNeshcheret · 2021-12-21T16:23:10Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1607685734
❌ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1607685734
🐛 https://gradle.com/s/cn7fqmdz2sjtw

sashaNeshcheret · 2021-12-22T14:33:18Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1611737224
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1611737224
No Python unittests run

sashaNeshcheret · 2021-12-22T14:34:10Z

/test connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1611740387
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1611740387
No Python unittests run

...-cockroachdb/src/main/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSource.java

…er-permissions-for-table-discover

sashaNeshcheret · 2021-12-24T12:07:08Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619121814
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619121814
No Python unittests run

sashaNeshcheret · 2021-12-24T12:24:00Z

/test connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619164629
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619164629
No Python unittests run

alexandr-shegeda

LGTM. we can proceed with publishing and merge without airbyte review

…er-permissions-for-table-discover # Conflicts: # airbyte-integrations/connectors/source-cockroachdb/src/test/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSourceTest.java # docs/integrations/sources/cockroachdb.md

sashaNeshcheret · 2021-12-24T13:09:29Z

/test connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619267669
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619267669
No Python unittests run

sashaNeshcheret · 2021-12-24T13:09:36Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619267979
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619267979
No Python unittests run

Did requested changes

sashaNeshcheret · 2021-12-24T13:39:47Z

/publish connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619338712
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1619338712

sashaNeshcheret · 2021-12-24T13:40:08Z

/publish connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619339459
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1619339459

Handled case when user can see only tables with select grants

cf0315e

github-actions bot added the area/connectors Connector related issues label Dec 21, 2021

jrhizor temporarily deployed to more-secrets December 21, 2021 16:25 Inactive

Fixed failed test for cockroachDB

aaae3b0

sashaNeshcheret temporarily deployed to more-secrets December 22, 2021 13:24 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 14:35 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 14:36 Inactive

sashaNeshcheret linked an issue Dec 22, 2021 that may be closed by this pull request

Source CockroachDB: Do not list tables in the connection settings if user do not have access to them #5172 #8868

Closed

format

a23aa8d

sashaNeshcheret temporarily deployed to more-secrets December 22, 2021 15:15 Inactive

sashaNeshcheret changed the title ~~Draft: Handled case when user can see only tables with select grants~~ Handled case when user can see only tables with select grants Dec 22, 2021

sashaNeshcheret requested review from mkhokh-33 and VitaliiMaltsev December 22, 2021 15:23

sashaNeshcheret mentioned this pull request Dec 22, 2021

[EPIC] Verify DB System tables and tables where user do not have privileges are not accessible to the user at Airbyte UI #8045

Closed

mkhokh-33 previously requested changes Dec 23, 2021

View reviewed changes

...-cockroachdb/src/main/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSource.java Show resolved Hide resolved

sashaNeshcheret added 3 commits December 23, 2021 10:23

Merge remote-tracking branch 'origin/master' into oneshcheret/8868-us…

5246221

…er-permissions-for-table-discover

added integration test

7866906

Merge remote-tracking branch 'origin/master' into oneshcheret/8868-us…

ec5e12a

…er-permissions-for-table-discover

sashaNeshcheret temporarily deployed to more-secrets December 24, 2021 12:04 Inactive

jrhizor temporarily deployed to more-secrets December 24, 2021 12:09 Inactive

sashaNeshcheret requested a review from mkhokh-33 December 24, 2021 12:10

jrhizor temporarily deployed to more-secrets December 24, 2021 12:25 Inactive

bump versions

615bc01

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 24, 2021

sashaNeshcheret requested a review from alexandr-shegeda December 24, 2021 12:35

sashaNeshcheret temporarily deployed to more-secrets December 24, 2021 12:36 Inactive

alexandr-shegeda approved these changes Dec 24, 2021

View reviewed changes

VitaliiMaltsev approved these changes Dec 24, 2021

View reviewed changes

sashaNeshcheret changed the title ~~Handled case when user can see only tables with select grants~~ Source CockroachDB: handled case when user can see only tables with select grants Dec 24, 2021

sashaNeshcheret added 2 commits December 24, 2021 14:56

bump versions

89f07e2

sashaNeshcheret temporarily deployed to more-secrets December 24, 2021 13:09 Inactive

jrhizor temporarily deployed to more-secrets December 24, 2021 13:11 Inactive

jrhizor temporarily deployed to more-secrets December 24, 2021 13:41 Inactive

sashaNeshcheret merged commit 6f4c3d1 into master Dec 24, 2021

sashaNeshcheret deleted the oneshcheret/8868-user-permissions-for-table-discover branch December 24, 2021 13:59

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

karinakuz added connectors/sources-database connectors/source/cockroachdb-strict-encrypt labels Jan 4, 2022

igrankova added the connectors/source/cockroachdb label Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source CockroachDB: handled case when user can see only tables with select grants #9004

Source CockroachDB: handled case when user can see only tables with select grants #9004

sashaNeshcheret commented Dec 21, 2021 •

edited

Loading

sashaNeshcheret commented Dec 21, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 22, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 22, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

Source CockroachDB: handled case when user can see only tables with select grants #9004

Source CockroachDB: handled case when user can see only tables with select grants #9004

Conversation

sashaNeshcheret commented Dec 21, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

sashaNeshcheret commented Dec 21, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 22, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 22, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

alexandr-shegeda left a comment

Choose a reason for hiding this comment

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 24, 2021 • edited by github-actions bot Loading

sashaNeshcheret commented Dec 21, 2021 •

edited

Loading

sashaNeshcheret commented Dec 21, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 22, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 22, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret commented Dec 24, 2021 •

edited by github-actions bot

Loading