-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source CockroachDB: handled case when user can see only tables with select grants #9004
Source CockroachDB: handled case when user can see only tables with select grants #9004
Conversation
/test connector=connectors/source-cockroachdb
|
/test connector=connectors/source-cockroachdb
|
/test connector=connectors/source-cockroachdb-strict-encrypt
|
...-cockroachdb/src/main/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSource.java
Show resolved
Hide resolved
…er-permissions-for-table-discover
…er-permissions-for-table-discover
/test connector=connectors/source-cockroachdb
|
/test connector=connectors/source-cockroachdb-strict-encrypt
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we can proceed with publishing and merge without airbyte review
…er-permissions-for-table-discover # Conflicts: # airbyte-integrations/connectors/source-cockroachdb/src/test/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSourceTest.java # docs/integrations/sources/cockroachdb.md
/test connector=connectors/source-cockroachdb-strict-encrypt
|
/test connector=connectors/source-cockroachdb
|
/publish connector=connectors/source-cockroachdb
|
/publish connector=connectors/source-cockroachdb-strict-encrypt
|
What
Handled case when user can see only tables with select grants, previously during discovery we fetch all tables regardless permissions.
How
Fetch tables names where user has select or all permissions and filter other tables from result.
Recommended reading order
x.java
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes