Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added associations to some CRM Object streams in Hubspot connector #9027

Closed
wants to merge 2 commits into from
Closed

Added associations to some CRM Object streams in Hubspot connector #9027

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ac6e8
Added associations to some CRM Object streams in Hubspot connector
ksoenandar Dec 22, 2021
52a4e3b
Added associations in the relevant schemas
ksoenandar Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airbyte-integrations/connectors/source-hubspot/source_hubspot/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ def __init__(self, start_date, credentials, **kwargs):
"campaigns": CampaignStream(**common_params),
"companies": CRMObjectIncrementalStream(entity="company", associations=["contacts"], **common_params),
"contact_lists": ContactListStream(**common_params),
"contacts": CRMObjectIncrementalStream(entity="contact", **common_params),
"contacts": CRMObjectIncrementalStream(entity="contact", associations=["companies"], **common_params),
"deal_pipelines": DealPipelineStream(**common_params),
"deals": DealStream(associations=["contacts"], **common_params),
"deals": DealStream(associations=["contacts", "companies"], **common_params),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new associations change the response from the API. You need to change the schema file to be compatible with the new response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course @marcosmarxm!

I've updated the schemas to include the relevant associations. Seems like the deals stream schema has always had the companies associations so I didn't add that.

"email_events": EmailEventStream(**common_params),
"engagements": EngagementStream(**common_params),
"forms": FormStream(**common_params),
Expand All @@ -48,7 +48,7 @@ def __init__(self, start_date, credentials, **kwargs):
"owners": OwnerStream(**common_params),
"products": CRMObjectIncrementalStream(entity="product", **common_params),
"subscription_changes": SubscriptionChangeStream(**common_params),
"tickets": CRMObjectIncrementalStream(entity="ticket", **common_params),
"tickets": CRMObjectIncrementalStream(entity="ticket", associations=["companies"], **common_params),
"workflows": WorkflowStream(**common_params),
}

Expand Down