Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Facebook Pages: removed deprecated field live_encoders from Page stream #9032

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

augan-rymkhan
Copy link
Contributor

@augan-rymkhan augan-rymkhan commented Dec 22, 2021

What

Resolves 8626

How

Removed deprecated field live_encoders from query params list and schema for Page stream.
image

Recommended reading order

  1. airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py
  2. airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/schemas/page.json

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 22, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets December 22, 2021 07:02 Inactive
@augan-rymkhan augan-rymkhan changed the title removed deprecated field live_encoders Source Facebook Pages: removed deprecated field live_encoders from Page stream Dec 22, 2021
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Dec 22, 2021

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1610237156
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1610237156
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        29     17    41%
	 source_facebook_pages/streams.py       74     34    54%
	 -------------------------------------------------------
	 TOTAL                                 109     51    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 14 passed, 1 skipped in 71.44s (0:01:11) ===================

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 07:13 Inactive
Copy link
Contributor

@eliziario eliziario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets December 23, 2021 10:47 Inactive
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Dec 23, 2021

/publish connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1615286467
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1615286467

@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 11:08 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets December 23, 2021 11:21 Inactive
@augan-rymkhan augan-rymkhan merged commit 4501ad0 into master Dec 23, 2021
@augan-rymkhan augan-rymkhan deleted the arymkhan/facebook-page-test-connection-fails branch December 23, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-pages connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Facebook Pages: Test connection failing (nonexisting field: live_encoders)
5 participants