CDK: Fix typing errors #9037

keu · 2021-12-22T11:25:20Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2021-12-22T11:25:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Augan93
❌ eugene-kulak
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

eliziario · 2021-12-22T13:22:35Z

airbyte-cdk/python/unit_tests/sources/streams/http/test_http.py


    def stream_slices(self, **kwargs) -> Iterable[Optional[Mapping[str, Any]]]:
        for path in self.paths:
            yield {"path": path}

    def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
-        yield response
+        yield {"value": len(response.text)}


Just out of curiosity, why this radical change?

it needs to be a mapping according to signature

eliziario

nice to me, have just one non-critical question

augan-rymkhan · 2022-01-12T16:57:34Z

/publish-cdk dry-run=false

❌ https://github.com/airbytehq/airbyte/actions/runs/1688741950
❌ https://github.com/airbytehq/airbyte/actions/runs/1688741950
❌ https://github.com/airbytehq/airbyte/actions/runs/1688741950
❌ https://github.com/airbytehq/airbyte/actions/runs/1688741950

augan-rymkhan · 2022-01-13T05:39:41Z

/publish-cdk dry-run=false

❌ https://github.com/airbytehq/airbyte/actions/runs/1691237088
❌ https://github.com/airbytehq/airbyte/actions/runs/1691237088
❌ https://github.com/airbytehq/airbyte/actions/runs/1691237088

augan-rymkhan · 2022-01-13T08:55:32Z

airbyte-cdk/python/unit_tests/sources/test_abstract_source.py

@@ -108,7 +108,7 @@ def test_discover(mocker):
    assert expected == src.discover(logger, {})


-def test_read_nonexistent_stream_raises_exception(mocker, logger):


Tests failed because of Fixture "logger" not found error
I removed logger fixture from the tests, so they will use logger defined in the same module.

The fixture logger was removed here in this PR.

augan-rymkhan · 2022-01-14T04:18:55Z

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/1696137538
✅ https://github.com/airbytehq/airbyte/actions/runs/1696137538

eugene-kulak added 2 commits December 22, 2021 13:18

fix typing, drop AirbyteLogger

28fb6c9

format

b1bff36

github-actions bot added the CDK Connector Development Kit label Dec 22, 2021

keu temporarily deployed to more-secrets December 22, 2021 11:26 Inactive

eliziario reviewed Dec 22, 2021

View reviewed changes

eliziario approved these changes Dec 22, 2021

View reviewed changes

keu temporarily deployed to more-secrets December 24, 2021 13:15 Inactive

bump the version

239544e

augan-rymkhan temporarily deployed to more-secrets January 12, 2022 16:56 Inactive

use logger instead of fixture logger

2cb50f0

augan-rymkhan temporarily deployed to more-secrets January 13, 2022 08:32 Inactive

augan-rymkhan requested review from sergei-solonitcyn and vitaliizazmic January 13, 2022 08:32

augan-rymkhan reviewed Jan 13, 2022

View reviewed changes

vitaliizazmic approved these changes Jan 13, 2022

View reviewed changes

augan-rymkhan merged commit f83eca5 into master Jan 14, 2022

augan-rymkhan deleted the keu/cdk-fix-typing-errors branch January 14, 2022 04:29

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

pedroslopez mentioned this pull request Jul 21, 2022

CDK: Run MyPy as part of CI #14907

Closed

MJafarMashhadi mentioned this pull request Nov 18, 2022

🐛 Source Pardot: failed while syncing Visitors stream #19618

Merged

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CDK: Fix typing errors #9037

CDK: Fix typing errors #9037

keu commented Dec 22, 2021

CLAassistant commented Dec 22, 2021 •

edited

Loading

eliziario Dec 22, 2021

keu Dec 24, 2021

eliziario left a comment

augan-rymkhan commented Jan 12, 2022 •

edited by github-actions bot

Loading

augan-rymkhan commented Jan 13, 2022 •

edited by github-actions bot

Loading

augan-rymkhan Jan 13, 2022 •

edited

Loading

augan-rymkhan commented Jan 14, 2022 •

edited by github-actions bot

Loading

		@@ -108,7 +108,7 @@ def test_discover(mocker):
		assert expected == src.discover(logger, {})


		def test_read_nonexistent_stream_raises_exception(mocker, logger):

CDK: Fix typing errors #9037

CDK: Fix typing errors #9037

Conversation

keu commented Dec 22, 2021

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Dec 22, 2021 • edited Loading

eliziario Dec 22, 2021

Choose a reason for hiding this comment

keu Dec 24, 2021

Choose a reason for hiding this comment

eliziario left a comment

Choose a reason for hiding this comment

augan-rymkhan commented Jan 12, 2022 • edited by github-actions bot Loading

augan-rymkhan commented Jan 13, 2022 • edited by github-actions bot Loading

augan-rymkhan Jan 13, 2022 • edited Loading

Choose a reason for hiding this comment

augan-rymkhan commented Jan 14, 2022 • edited by github-actions bot Loading

CLAassistant commented Dec 22, 2021 •

edited

Loading

augan-rymkhan commented Jan 12, 2022 •

edited by github-actions bot

Loading

augan-rymkhan commented Jan 13, 2022 •

edited by github-actions bot

Loading

augan-rymkhan Jan 13, 2022 •

edited

Loading

augan-rymkhan commented Jan 14, 2022 •

edited by github-actions bot

Loading