🐛 Destination Snowflake | BigQuery: add part_size config to UI #9039

yurii-bidiuk · 2021-12-22T12:03:44Z

What

Fixes #5720 #6245 #8990

How

Add part_size config for Snowflake S3 loading method;
add part_size config for BigQuery "GCS Staging" loading method;

🚨 User Impact 🚨

There are no breaking changes. Added new config properties to UI

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

yurii-bidiuk · 2021-12-22T15:27:29Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1611945416
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1611945416
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

yurii-bidiuk · 2021-12-22T15:28:17Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1611948164
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1611948164
🐛

yurii-bidiuk · 2021-12-22T15:28:27Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1611948630
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1611948630
🐛

yurii-bidiuk · 2021-12-22T15:36:58Z

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

+                type: "integer"
+                default: 5
+                examples:
+                - 5


yurii-bidiuk · 2021-12-22T15:37:28Z

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

+                type: "integer"
+                default: 5
+                examples:
+                - 5


yurii-bidiuk · 2021-12-22T15:38:41Z

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

+                  \ A rule of thumb is to multiply the part size by 10 to get the\
+                  \ memory requirement. Modify this with care."
+                title: "Stream Part Size"
+                order: 5


alexandertsukanov · 2021-12-23T09:33:01Z

Looks good. Approve from my side.

yurii-bidiuk · 2021-12-23T09:39:00Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1615001049
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1615001049
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

alexandertsukanov · 2021-12-23T09:39:03Z

airbyte-integrations/connectors/destination-bigquery-denormalized/src/main/resources/spec.json

+              "part_size_mb": {
+                "title": "Block Size (MB) for GCS multipart upload",
+                "description": "This is the size of a \"Part\" being buffered in memory. It limits the memory usage when writing. Larger values will allow to upload a bigger files and improve the speed, but consumes9 more memory. Allowed values: min=5MB, max=525MB Default: 5MB.",
+                "type": "integer",
+                "default": 5,
+                "examples": [5]
+              },


[Optional] Please take a look if we have an option to limit the input. To make possible enter only integers in range 5 - 525.

alexandertsukanov · 2021-12-23T09:40:09Z

airbyte-integrations/connectors/destination-bigquery/src/main/resources/spec.json

+              "part_size_mb": {
+                "title": "Block Size (MB) for GCS multipart upload",
+                "description": "This is the size of a \"Part\" being buffered in memory. It limits the memory usage when writing. Larger values will allow to upload a bigger files and improve the speed, but consumes9 more memory. Allowed values: min=5MB, max=525MB Default: 5MB.",
+                "type": "integer",
+                "default": 5,
+                "examples": [5]
+              },


The comment above related to this spec, also.

yurii-bidiuk · 2021-12-23T11:07:42Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1615292833
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1615292833
No Python unittests run

VitaliiMaltsev · 2021-12-23T11:23:48Z

this PR covers only UI part. So does backend for Destination Snowflake and BigQuery already can handle this new features with part size ore it should be done in scope of other task?

alexandr-shegeda

LGTM. we can proceed with publishing and merging without airbyte review

VitaliiMaltsev · 2021-12-23T17:43:47Z

@yurii-bidiuk please check github webhook /test command for both connectors with latest credentials version in Google Secret Manager (which include "part_size") before merging

yurii-bidiuk · 2021-12-23T18:00:49Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1616581400
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1616581400
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

yurii-bidiuk · 2021-12-23T18:05:08Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1616596492
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1616596492
No Python unittests run

yurii-bidiuk · 2021-12-23T18:05:14Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1616596664
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1616596664
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

yurii-bidiuk · 2021-12-23T19:05:20Z

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1616762433
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1616762433

yurii-bidiuk · 2021-12-23T19:05:58Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1616764321
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1616764321

yurii-bidiuk · 2021-12-23T19:06:02Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1616764447
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1616764447

github-actions bot added the area/connectors Connector related issues label Dec 22, 2021

yurii-bidiuk linked an issue Dec 22, 2021 that may be closed by this pull request

Stream was allocated the part numbers from 1 (inclusive) to 10001 (exclusive)and it has gone beyond the end #6245

Closed

yurii-bidiuk temporarily deployed to more-secrets December 22, 2021 12:59 Inactive

yurii-bidiuk linked an issue Dec 22, 2021 that may be closed by this pull request

Destinations BigQuery and BigQuery-denormalized: Modifying the specification to make possible set part_size_mb in UI #8990

Closed

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021

yurii-bidiuk temporarily deployed to more-secrets December 22, 2021 15:17 Inactive

yurii-bidiuk requested review from VitaliiMaltsev, alexandertsukanov and mkhokh-33 December 22, 2021 15:23

jrhizor temporarily deployed to more-secrets December 22, 2021 15:29 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 15:30 Inactive

yurii-bidiuk commented Dec 22, 2021

View reviewed changes

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

type: "integer"

default: 5

examples:

- 5

Copy link

Contributor Author

yurii-bidiuk Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yurii-bidiuk commented Dec 22, 2021

View reviewed changes

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

type: "integer"

default: 5

examples:

- 5

Copy link

Contributor Author

yurii-bidiuk Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yurii-bidiuk commented Dec 22, 2021

View reviewed changes

alexandertsukanov approved these changes Dec 23, 2021

View reviewed changes

alexandertsukanov reviewed Dec 23, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets December 23, 2021 09:40 Inactive

mkhokh-33 approved these changes Dec 23, 2021

View reviewed changes

yurii-bidiuk temporarily deployed to more-secrets December 23, 2021 11:05 Inactive

alexandertsukanov mentioned this pull request Dec 23, 2021

🎉 Destination Snowflake and RedShift: Implement the Byte-buffered logic #8869

Merged

40 tasks

jrhizor temporarily deployed to more-secrets December 23, 2021 11:09 Inactive

yurii-bidiuk temporarily deployed to more-secrets December 23, 2021 16:05 Inactive

yurii-bidiuk requested a review from alexandr-shegeda December 23, 2021 16:36

alexandr-shegeda approved these changes Dec 23, 2021

View reviewed changes

alexandr-shegeda marked this pull request as ready for review December 23, 2021 17:30

jrhizor temporarily deployed to more-secrets December 23, 2021 18:02 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 18:07 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 19:07 Inactive

yurii-bidiuk merged commit 14c3536 into master Dec 23, 2021

yurii-bidiuk deleted the bidiuk/5720-add-part-size branch December 23, 2021 20:23

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

karinakuz added connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destinations-api connectors/destinations-warehouse connectors/destination/snowflake and removed connectors/destinations-api labels Jan 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination Snowflake | BigQuery: add part_size config to UI #9039

🐛 Destination Snowflake | BigQuery: add part_size config to UI #9039

yurii-bidiuk commented Dec 22, 2021 •

edited

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk Dec 22, 2021

yurii-bidiuk Dec 22, 2021

yurii-bidiuk Dec 22, 2021

alexandertsukanov commented Dec 23, 2021

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

alexandertsukanov Dec 23, 2021

alexandertsukanov Dec 23, 2021

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 23, 2021

alexandr-shegeda left a comment

VitaliiMaltsev commented Dec 23, 2021 •

edited

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

🐛 Destination Snowflake | BigQuery: add part_size config to UI #9039

🐛 Destination Snowflake | BigQuery: add part_size config to UI #9039

Conversation

yurii-bidiuk commented Dec 22, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

yurii-bidiuk commented Dec 22, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 22, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 22, 2021 • edited by github-actions bot Loading

yurii-bidiuk Dec 22, 2021

Choose a reason for hiding this comment

yurii-bidiuk Dec 22, 2021

Choose a reason for hiding this comment

yurii-bidiuk Dec 22, 2021

Choose a reason for hiding this comment

alexandertsukanov commented Dec 23, 2021

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

alexandertsukanov Dec 23, 2021

Choose a reason for hiding this comment

alexandertsukanov Dec 23, 2021

Choose a reason for hiding this comment

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 23, 2021

alexandr-shegeda left a comment

Choose a reason for hiding this comment

VitaliiMaltsev commented Dec 23, 2021 • edited Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 23, 2021 • edited by github-actions bot Loading

yurii-bidiuk commented Dec 22, 2021 •

edited

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 22, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 23, 2021 •

edited

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading

yurii-bidiuk commented Dec 23, 2021 •

edited by github-actions bot

Loading