Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Google search console: add 'order' to spec.json props #9047

Merged
merged 4 commits into from
Dec 23, 2021

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Dec 22, 2021

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Screenshot 2021-12-22 at 17 03 57

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Dec 22, 2021
@grubberr grubberr temporarily deployed to more-secrets December 22, 2021 15:01 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 22, 2021
@grubberr grubberr linked an issue Dec 22, 2021 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021
@grubberr grubberr temporarily deployed to more-secrets December 22, 2021 15:04 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please publish this

@grubberr
Copy link
Contributor Author

grubberr commented Dec 22, 2021

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612568277
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612568277
🐛 https://gradle.com/s/ijcmec3sqywtk
Python short test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
=================== 1 failed, 16 passed in 79.50s (0:01:19) ====================

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 18:29 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Dec 22, 2021

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612694512
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612694512
🐛 https://gradle.com/s/34o7pcwzly6uq
Python short test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
=================== 1 failed, 16 passed in 90.50s (0:01:30) ====================

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 19:09 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Dec 22, 2021

/publish connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612975521
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1612975521

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 20:40 Inactive
@grubberr
Copy link
Contributor Author

current incremental tests FAILED, PR #8798

@grubberr
Copy link
Contributor Author

grubberr commented Dec 23, 2021

/publish connector=connectors/source-google-search-console run-tests=false

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1617152646
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/1617152646

@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 21:38 Inactive
@grubberr grubberr merged commit a7b906b into master Dec 23, 2021
@grubberr grubberr deleted the grubberr/7851-source-google-search-console branch December 23, 2021 21:52
@grubberr grubberr temporarily deployed to more-secrets December 23, 2021 21:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder Google Search Console config fields
3 participants