-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multi-stage builds in dockerfiles to reduce java images #9077
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
This reverts commit b7ab21a.
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/destination-dynamodb
|
/test connector=connectors/source-mssql
|
/test connector=connectors/destination-azure-blob-storage
|
/test connector=connectors/destination-bigquery-denormalized
|
/test connector=connectors/destination-csv
|
/test connector=connectors/destination-e2e-test
|
/test connector=connectors/source-mongodb-strict-encrypt
|
/test connector=connectors/source-mongodb-v2
|
/test connector=connectors/source-snowflake
|
/test connector=connectors/source-kafka
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. we can proceed with merge without airbyte review
@grubberr, it looks like that the master build started to fail on the |
@tuliren there is a problem with class
and this tests
I have investigated a little and I see that this randomness Line 318 in a36a860
can generate different size of final json objects I will also investigate more about this problem |
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
We can reduce final docker image size by subtracting size of
${APPLICATION}.tar
fileFor example :
How
One appoach we can do it using docker multi-stage builds:
on first stage we unpack and remove tar file and copy contants of
/workdir
on 2-nd stageRecommended reading order
airbyte-integrations/bases/*
airbyte-integrations/connector-templates/*
airbyte-integrations/connectors/*
🚨 User Impact 🚨
No.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes